riscv: better CTR messages in pmap_enter_l2()
ClosedPublic
Actions

Authored by mhorne on Sep 14 2022, 2:19 PM.

Details

Reviewers

markj
jhb

Group Reviewers

riscv

Commits

rG3fd429a7ba29: riscv: better CTR messages in pmap_enter_l2()
rGdd18b62cec62: riscv: better CTR messages in pmap_enter_l2()

Summary

Disambiguate the failure cases.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mhorne created this revision.Sep 14 2022, 2:19 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 14 2022, 2:19 PM

mhorne requested review of this revision.Sep 14 2022, 2:19 PM

Harbormaster completed remote builds in B47377: Diff 110546.Sep 14 2022, 2:19 PM

jrtc27 added a subscriber: jrtc27.Sep 14 2022, 2:25 PM

jrtc27 added inline comments.

sys/riscv/riscv/pmap.c
3236	couldn't above, could not here?

I don't care strongly, but I would maybe reword these further, e.g.

"pmap_enter_l2: failed to allocate PT page for va %#lx in pmap %p"

That is, substitute the more detailed explanation for "failure" in the original logs.

This revision is now accepted and ready to land.Sep 30 2022, 9:41 PM

Closed by commit rGdd18b62cec62: riscv: better CTR messages in pmap_enter_l2() (authored by mhorne). · Explain WhyOct 6 2022, 10:06 PM

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rGdd18b62cec62: riscv: better CTR messages in pmap_enter_l2().

mhorne added a commit: rG3fd429a7ba29: riscv: better CTR messages in pmap_enter_l2().Oct 9 2022, 5:04 PM

Revision Contents
Changeset List

Path

Size

sys/

riscv/

pmap.c

12 lines

Diff 111522

View Options

riscv: better CTR messages in pmap_enter_l2()ClosedPublicActions