Page MenuHomeFreeBSD

stand: Stop support booting 4.x and earlier kernels
ClosedPublic

Authored by imp on Sep 12 2022, 11:40 PM.
Tags
None
Referenced Files
F83961287: D36543.diff
Fri, May 17, 10:43 AM
Unknown Object (File)
Sat, Apr 20, 7:21 PM
Unknown Object (File)
Mar 26 2024, 12:03 AM
Unknown Object (File)
Mar 11 2024, 9:06 AM
Unknown Object (File)
Mar 9 2024, 2:15 AM
Unknown Object (File)
Mar 9 2024, 2:11 AM
Unknown Object (File)
Mar 7 2024, 11:11 PM
Unknown Object (File)
Jan 6 2024, 5:09 PM
Subscribers

Details

Summary

FreeBSD 4.x and earlier used the bi_bios_geom to get the geometry of the
device. Starting in 5.x it was used only in pc98 kernels to report
geometry of the drives. It can be safely removed, but place behind
LOADER_SUPPORT_PRE_5X_KERNEL for the moment. This saves 176 bytes in the
BIOS loader.

Sponsored by: Netflix

Test Plan

I'm pretty sure we no longer need this, and we don't really need to boot old kernels.
In an ideal world, we'd set some flag, but there's no flag value other than != 0
While we used to return the 1.2MB Floppy geometry for unknown / in valid
drives, that's not checked in any meaningful way in the kernels I looked at.
They are fine being 0 for any kernel any normal person (and like any extreme
special case / extreme use people), and there's no need to preserve them and
we wind up saving a few bytes in the process...

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Sep 12 2022, 11:40 PM
imp added a reviewer: jhb.

question for reviewers: #ifdef or rm code?

adrian added a subscriber: adrian.

i think it's fine to nuke it?

This revision is now accepted and ready to land.Sep 12 2022, 11:50 PM