Page MenuHomeFreeBSD
Differential D36501

lio: Remove unneeded include.
ClosedPublic
Actions

Authored by zlei on Sep 9 2022, 2:44 AM.
Tags
None
Referenced Files
F166830149: D36501.id110826.diff
Sun, Aug 16, 9:43 PM
F166805120: D36501.id110372.diff
Sun, Aug 16, 7:38 PM
Unknown Object (File)
Sat, Aug 15, 9:25 PM
Unknown Object (File)
Sat, Aug 15, 8:33 PM
Unknown Object (File)
Fri, Aug 14, 7:36 PM
Unknown Object (File)
Fri, Aug 14, 6:26 PM
Unknown Object (File)
Wed, Aug 12, 3:33 PM
Unknown Object (File)
Sat, Aug 8, 7:55 PM
View All Files
Subscribers
imp
kp
melifaro

Details

Reviewers
sbruno
adrian
imp
Group Reviewers
network
Commits
rGd89fd4115ecd: lio: Remove unneeded include
rG0d44c5ae3735: lio: Remove unneeded include
rGd819ddba9aa4: lio: Remove unneeded include.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

zlei created this revision.Sep 9 2022, 2:44 AM
Herald added a subscriber: imp. · View Herald TranscriptSep 9 2022, 2:44 AM
zlei requested review of this revision.Sep 9 2022, 2:44 AM
zlei added a reviewer: network.Sep 21 2022, 3:53 AM
zlei added a comment.Sep 21 2022, 3:55 AM

It seems @sbruno is busy, add network group reviewers.

adrian accepted this revision as: adrian.Sep 21 2022, 5:18 AM
This revision is now accepted and ready to land.Sep 21 2022, 5:18 AM
imp accepted this revision.Sep 21 2022, 2:05 PM
Closed by commit rGd819ddba9aa4: lio: Remove unneeded include. (authored by zlei, committed by imp). · Explain WhySep 21 2022, 8:55 PM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rGd819ddba9aa4: lio: Remove unneeded include..
zlei added a subscriber: kp.EditedJan 11 2023, 8:49 AM

Hi @imp ,

I have WIP https://reviews.freebsd.org/D37758 and once it is done I'd like to MFC it into stable/13.
The gif(4) internal structure might change in final revision so I'd like to MFC this into stable branches.

I have commit privilege now, then what's your opinion ?

Also CC @kp @melifaro

zlei added a subscriber: melifaro.Jan 11 2023, 8:49 AM
imp added a comment.Jan 11 2023, 9:29 PM
In D36501#863598, @zlei wrote:

Hi @imp ,

I have WIP https://reviews.freebsd.org/D37758 and once it is done I'd like to MFC it into stable/13.
The gif(4) internal structure might change in final revision so I'd like to MFC this into stable branches.

I have commit privilege now, then what's your opinion ?

This seems sane to MFC. I don't anticipate there being any externally visible issue. I've not MFC'd it only because I've had my head down in kboot for too long.

zlei added a commit: rG0d44c5ae3735: lio: Remove unneeded include.Jan 19 2023, 3:46 PM
zlei added a commit: rGd89fd4115ecd: lio: Remove unneeded include.Jan 19 2023, 3:51 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
liquidio/
1 line

Diff 110826

View Options

sys/dev/liquidio/lio_bsd.h

Loading...