pmap_mapdev: Consistently use vm_paddr_t for the first argument.
ClosedPublic
Actions

Authored by jhb on Jul 26 2022, 10:37 PM.

Details

Reviewers

markj
jrtc27
andrew
manu

Commits

rGea8f128c7c17: pmap_mapdev: Consistently use vm_paddr_t for the first argument.

Summary

The devmap variants used vm_offset_t for some reason, and a few places
explicitly cast bus addresses to vm_offset_t. (Probably those casts
along with similar casts for vm_size_t should just be removed and
instead permit the compiler to DTRT.)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Jul 26 2022, 10:37 PM

Herald added a reviewer: manu. · View Herald TranscriptJul 26 2022, 10:37 PM

Herald added subscribers: jhibbits, emaste, imp. · View Herald Transcript

jhb requested review of this revision.Jul 26 2022, 10:37 PM

Harbormaster completed remote builds in B46619: Diff 108582.Jul 26 2022, 10:37 PM

markj accepted this revision.Jul 27 2022, 3:19 PM

This revision is now accepted and ready to land.Jul 27 2022, 3:19 PM

jhb added inline comments.Jul 27 2022, 5:19 PM

sys/kern/subr_devmap.c
273	This can probably be reverted back to trunc_page? I think I was just overly cautious.
293	It might be a nice followup if pmap_mapdev() on aarch64 and risc-v just called pmap_mapdev_attr() so we could avoid code duplication.