Page MenuHomeFreeBSD

Remove unused but set variable in cxgb_sge
ClosedPublic

Authored by dim on Jul 16 2022, 6:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 18, 10:42 AM
Unknown Object (File)
Mon, Nov 17, 6:38 AM
Unknown Object (File)
Wed, Nov 12, 9:30 AM
Unknown Object (File)
Tue, Nov 11, 2:38 AM
Unknown Object (File)
Oct 25 2025, 5:32 AM
Unknown Object (File)
Oct 20 2025, 4:17 PM
Unknown Object (File)
Oct 20 2025, 1:29 PM
Unknown Object (File)
Oct 16 2025, 11:02 PM
Subscribers

Details

Summary

Clang 15 warns:

sys/dev/cxgb/cxgb_sge.c:1290:21: error: variable 'txsd' set but not used [-Werror,-Wunused-but-set-variable]
        struct tx_sw_desc *txsd = &txq->sdesc[txqs->pidx];
                           ^

It appears 'txsd' is a leftover from a previous refactoring (see
3f345a5d09b6), but is no longer used for anything, and can be removed
without any functional change.

MFC after: 3 days

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 46458
Build 43347: arc lint + arc unit