Page MenuHomeFreeBSD

Remove unused but set variable in cxgb_sge
ClosedPublic

Authored by dim on Jul 16 2022, 6:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Aug 10, 10:49 AM
Unknown Object (File)
Fri, Aug 7, 5:27 PM
Unknown Object (File)
Fri, Aug 7, 6:46 AM
Unknown Object (File)
Thu, Aug 6, 12:30 PM
Unknown Object (File)
Wed, Aug 5, 6:57 AM
Unknown Object (File)
Mon, Jul 20, 1:44 PM
Unknown Object (File)
Jun 28 2026, 8:49 AM
Unknown Object (File)
Jun 27 2026, 8:50 AM
Subscribers

Details

Summary

Clang 15 warns:

sys/dev/cxgb/cxgb_sge.c:1290:21: error: variable 'txsd' set but not used [-Werror,-Wunused-but-set-variable]
        struct tx_sw_desc *txsd = &txq->sdesc[txqs->pidx];
                           ^

It appears 'txsd' is a leftover from a previous refactoring (see
3f345a5d09b6), but is no longer used for anything, and can be removed
without any functional change.

MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable