Page MenuHomeFreeBSD

arm64/amd64: add options IOMMU to LINT
AbandonedPublic

Authored by mhorne on Jun 23 2022, 6:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 1 2024, 6:36 AM
Unknown Object (File)
Nov 25 2023, 11:43 PM
Unknown Object (File)
Nov 23 2023, 2:34 PM
Unknown Object (File)
Nov 23 2023, 6:20 AM
Unknown Object (File)
Jun 21 2023, 1:28 PM
Unknown Object (File)
Apr 6 2023, 10:45 AM
Unknown Object (File)
Mar 5 2023, 5:46 PM
Unknown Object (File)
Feb 17 2023, 3:06 AM
Subscribers

Details

Reviewers
kib
br
manu

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 46097
Build 42986: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Jun 24 2022, 9:11 AM

Why did you removed IOMMU from i386 LINT?
Also, I do not think that adding IOMMU to LINT on amd64/arm64 is right.

The idea of LINT is to be complimentary to GENERIC, so that make universe checks as much code as possible. Adding the IOMMU option to both LINT and GENERIC makes the configuration without IOMMU not compile-time checked. [This is why IOMMU is in i386 LINT but not GENERIC]

In D35579#807168, @kib wrote:

Why did you removed IOMMU from i386 LINT?
Also, I do not think that adding IOMMU to LINT on amd64/arm64 is right.

The idea of LINT is to be complimentary to GENERIC, so that make universe checks as much code as possible. Adding the IOMMU option to both LINT and GENERIC makes the configuration without IOMMU not compile-time checked. [This is why IOMMU is in i386 LINT but not GENERIC]

It is somewhat confusing because NOTES acts both as a source for LINT and as documentation of all existing config options. So it is easy to think "the LINT config builds everything".

But you are right, as usual, that having this option excluded from LINT is much more useful, and more in line with its actual purpose.