Page MenuHomeFreeBSD

crypto: Provide a routine to reset cryptops after EAGAIN
AcceptedPublic

Authored by markj on Jun 20 2022, 7:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 5:28 AM
Unknown Object (File)
Dec 20 2023, 6:03 AM
Unknown Object (File)
Dec 15 2023, 4:34 AM
Unknown Object (File)
Nov 9 2023, 1:13 PM
Unknown Object (File)
Nov 8 2023, 10:10 AM
Unknown Object (File)
Nov 7 2023, 7:38 PM
Unknown Object (File)
Oct 8 2023, 12:09 PM
Unknown Object (File)
Oct 7 2023, 9:07 AM

Details

Reviewers
jhb
pauamma_gundo.com
Group Reviewers
manpages
Summary

Some consumers handle EAGAIN properly, some do not. Rather than
requiring all consumers to fiddle with crypto fields before retrying an
operating, provide a subroutine to do it.

Use it in GELI, which wasn't clearing CRYPTO_F_DONE before retrying.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 46478
Build 43367: arc lint + arc unit

Event Timeline

markj requested review of this revision.Jun 20 2022, 7:12 PM

I think there's also some code in kgssapi/ that should be updated as well?

This revision is now accepted and ready to land.Jun 30 2022, 5:42 PM

(Also, probably add to crypto_request.9?)

  • Update the crypto_request man page
  • Add missing calls kgssapi and ipsec
This revision now requires review to proceed.Jul 19 2022, 4:39 PM

One minor nit that can be fixed at commit.

share/man/man9/crypto_request.9
147

No comma for a 2-item list.

This revision is now accepted and ready to land.Jul 23 2022, 12:08 AM
jhb added inline comments.
sys/opencrypto/crypto.c
1758