Page MenuHomeFreeBSD

routing: fix RTM_CHANGE for multipath #1
ClosedPublic

Authored by melifaro on Jun 19 2022, 8:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 11, 5:48 AM
Unknown Object (File)
Fri, Sep 11, 3:56 AM
Unknown Object (File)
Sun, Sep 6, 9:15 PM
Unknown Object (File)
Sun, Sep 6, 9:10 AM
Unknown Object (File)
Sat, Sep 5, 8:59 PM
Unknown Object (File)
Sat, Sep 5, 7:42 AM
Unknown Object (File)
Fri, Sep 4, 7:15 PM
Unknown Object (File)
Fri, Sep 4, 5:36 AM
Subscribers

Details

Summary

RTM_CHANGE is supposed to operate on a single component of the multipath route (e.g. on a single nexthop). Search of this nexthop is peformed by iterating over each nexthop from multipath (nexthop) group, using check_info_match_nhop. The problem with the current code that it (incorrectly assumes that check_info_match_nhop() returns true value on match, while in reality it returns an error code on failure).
Fix this by properly comparing the result with 0.

Next, the followup code creating a new nexthop group, was modifying original group instead of a new one, leading to the spurious errors.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable