Page MenuHomeFreeBSD

bhyve nvme: Check return value of mapped memory
ClosedPublic

Authored by chuck on Jun 10 2022, 8:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 12 2024, 4:23 AM
Unknown Object (File)
Jan 22 2024, 5:00 PM
Unknown Object (File)
Dec 20 2023, 5:08 AM
Unknown Object (File)
Dec 18 2023, 3:34 AM
Unknown Object (File)
Nov 7 2023, 9:32 PM
Unknown Object (File)
Nov 4 2023, 4:01 PM
Unknown Object (File)
Oct 11 2023, 12:31 PM
Unknown Object (File)
Sep 29 2023, 3:39 PM
Subscribers

Details

Summary

Fuzzing of bhyve using hyfuzz discovered a way to cause a segmentation
fault in the NVMe emulation. If a guest specifies a physical address in
either the PRP1 or PRP2 field of a command that cannot be mapped from
guest to host, the function paddr_guest2host() returns a NULL pointer.
The NVMe emulation did not check for this error case, which allowed for
the segmentation fault to occur.

Fix is to check for a return value of NULL and indicate an error back to
the guest (Data Transfer error). While in the area, slightly refactor
the write/read blockif function to use a common error exit path.

PR: 256321
Reported by: Cheolwoo Myung <cwmyung@snu.ac.kr>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable