dummynet: do not store struct ifnet pointers
ClosedPublic
Actions

Authored by kp on May 19 2022, 5:00 PM.

Details

Reviewers

None

Group Reviewers

network
pfsense

Commits

rG12c542cd0e9e: dummynet: do not store struct ifnet pointers

Summary

The dn_pkt_tag tag contained a struct ifnet pointer. If we persist that
across NET_EPOCH boundaries (as we did in dummynet) we risk panics if
the interface is removed between the packet being enqueued and it being
dequeued.

Convert the pointer into an index/generation pair and restore it when
the packet is taken out of the queue.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.May 19 2022, 5:00 PM

Herald added subscribers: glebius, donner, melifaro and 2 others. · View Herald TranscriptMay 19 2022, 5:00 PM

kp requested review of this revision.May 19 2022, 5:00 PM

Harbormaster completed remote builds in B45633: Diff 106167.May 19 2022, 5:00 PM

kp added a child revision: D35257: pf: call dummynet directly from the ethernet code.May 19 2022, 5:00 PM

This revision was not accepted when it landed; it landed in state Needs Review.May 20 2022, 12:51 PM

Closed by commit rG12c542cd0e9e: dummynet: do not store struct ifnet pointers (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG12c542cd0e9e: dummynet: do not store struct ifnet pointers.

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

ipfw/

ip_dn_io.c

10 lines

ip_dn_private.h

3 lines

Diff 106203

View Options

sys/netpfil/ipfw/ip_dn_io.c

	Show First 20 Lines • Show All 269 Lines • ▼ Show 20 Lines
	include/clc/workitem/get_global_id.h			include/clc/workitem/get_global_id.h
	include/clc/workitem/get_global_offset.h			include/clc/workitem/get_global_offset.h
	include/clc/workitem/get_global_size.h			include/clc/workitem/get_global_size.h
	include/clc/workitem/get_group_id.h			include/clc/workitem/get_group_id.h
	include/clc/workitem/get_local_id.h			include/clc/workitem/get_local_id.h
	include/clc/workitem/get_local_size.h			include/clc/workitem/get_local_size.h
	include/clc/workitem/get_num_groups.h			include/clc/workitem/get_num_groups.h
	include/clc/workitem/get_work_dim.h			include/clc/workitem/get_work_dim.h
	lib/clc/amdgcn--amdhsa.bc
	lib/clc/aruba-r600--.bc
	lib/clc/barts-r600--.bc
	lib/clc/bonaire-amdgcn--.bc
	lib/clc/bonaire-amdgcn--amdhsa.bc
	lib/clc/bonaire-amdgcn-mesa-mesa3d.bc
	lib/clc/caicos-r600--.bc
	lib/clc/carrizo-amdgcn--.bc
	lib/clc/carrizo-amdgcn--amdhsa.bc
	lib/clc/carrizo-amdgcn-mesa-mesa3d.bc
	lib/clc/cayman-r600--.bc
	lib/clc/cedar-r600--.bc
	lib/clc/cypress-r600--.bc
	lib/clc/fiji-amdgcn--.bc
	lib/clc/fiji-amdgcn--amdhsa.bc
	lib/clc/fiji-amdgcn-mesa-mesa3d.bc
	lib/clc/gfx900-amdgcn--.bc
	lib/clc/gfx900-amdgcn--amdhsa.bc
	lib/clc/gfx900-amdgcn-mesa-mesa3d.bc
	lib/clc/gfx902-amdgcn--.bc
	lib/clc/gfx902-amdgcn--amdhsa.bc
	lib/clc/gfx902-amdgcn-mesa-mesa3d.bc
	lib/clc/gfx904-amdgcn--.bc
	lib/clc/gfx904-amdgcn--amdhsa.bc
	lib/clc/gfx904-amdgcn-mesa-mesa3d.bc
	lib/clc/gfx906-amdgcn--.bc
	lib/clc/gfx906-amdgcn--amdhsa.bc
	lib/clc/gfx906-amdgcn-mesa-mesa3d.bc
	lib/clc/hainan-amdgcn--.bc
	lib/clc/hainan-amdgcn-mesa-mesa3d.bc
	lib/clc/hawaii-amdgcn--.bc
	lib/clc/hawaii-amdgcn--amdhsa.bc
	lib/clc/hawaii-amdgcn-mesa-mesa3d.bc
	lib/clc/hemlock-r600--.bc
	lib/clc/iceland-amdgcn--.bc
	lib/clc/iceland-amdgcn--amdhsa.bc
	lib/clc/iceland-amdgcn-mesa-mesa3d.bc
	lib/clc/juniper-r600--.bc
	lib/clc/kabini-amdgcn--.bc
	lib/clc/kabini-amdgcn--amdhsa.bc
	lib/clc/kabini-amdgcn-mesa-mesa3d.bc
	lib/clc/kaveri-amdgcn--.bc
	lib/clc/kaveri-amdgcn--amdhsa.bc
	lib/clc/kaveri-amdgcn-mesa-mesa3d.bc
	lib/clc/mullins-amdgcn--.bc
	lib/clc/mullins-amdgcn--amdhsa.bc
	lib/clc/mullins-amdgcn-mesa-mesa3d.bc
	lib/clc/nvptx--nvidiacl.bc
	lib/clc/nvptx64--nvidiacl.bc
	lib/clc/oland-amdgcn--.bc
	lib/clc/oland-amdgcn-mesa-mesa3d.bc
	lib/clc/palm-r600--.bc
	lib/clc/pitcairn-amdgcn--.bc
	lib/clc/pitcairn-amdgcn-mesa-mesa3d.bc
	lib/clc/polaris10-amdgcn--.bc
	lib/clc/polaris10-amdgcn--amdhsa.bc
	lib/clc/polaris10-amdgcn-mesa-mesa3d.bc
	lib/clc/polaris11-amdgcn--.bc
	lib/clc/polaris11-amdgcn--amdhsa.bc
	lib/clc/polaris11-amdgcn-mesa-mesa3d.bc
	lib/clc/redwood-r600--.bc
	lib/clc/stoney-amdgcn--.bc
	lib/clc/stoney-amdgcn--amdhsa.bc
	lib/clc/stoney-amdgcn-mesa-mesa3d.bc
	lib/clc/subnormal_disable.bc
	lib/clc/subnormal_use_default.bc
	lib/clc/sumo-r600--.bc
	lib/clc/sumo2-r600--.bc
	lib/clc/tahiti-amdgcn--.bc
	lib/clc/tahiti-amdgcn-mesa-mesa3d.bc
	lib/clc/tonga-amdgcn--.bc
	lib/clc/tonga-amdgcn--amdhsa.bc
	lib/clc/tonga-amdgcn-mesa-mesa3d.bc
	lib/clc/turks-r600--.bc
	lib/clc/verde-amdgcn--.bc
	lib/clc/verde-amdgcn-mesa-mesa3d.bc
	libdata/pkgconfig/libclc.pc			libdata/pkgconfig/libclc.pc
				share/clc/amdgcn--amdhsa.bc
				share/clc/aruba-r600--.bc
				share/clc/barts-r600--.bc
				share/clc/bonaire-amdgcn--.bc
				share/clc/bonaire-amdgcn-mesa-mesa3d.bc
				share/clc/caicos-r600--.bc
				share/clc/carrizo-amdgcn--.bc
				share/clc/carrizo-amdgcn-mesa-mesa3d.bc
				share/clc/cayman-r600--.bc
				share/clc/cedar-r600--.bc
				share/clc/cypress-r600--.bc
				share/clc/fiji-amdgcn--.bc
				share/clc/fiji-amdgcn-mesa-mesa3d.bc
				share/clc/gfx900-amdgcn--.bc
				share/clc/gfx900-amdgcn-mesa-mesa3d.bc
				share/clc/gfx902-amdgcn--.bc
				share/clc/gfx902-amdgcn-mesa-mesa3d.bc
				share/clc/gfx904-amdgcn--.bc
				share/clc/gfx904-amdgcn-mesa-mesa3d.bc
				share/clc/gfx906-amdgcn--.bc
				share/clc/gfx906-amdgcn-mesa-mesa3d.bc
				share/clc/hainan-amdgcn--.bc
				share/clc/hainan-amdgcn-mesa-mesa3d.bc
				share/clc/hawaii-amdgcn--.bc
				share/clc/hawaii-amdgcn-mesa-mesa3d.bc
				share/clc/hemlock-r600--.bc
				share/clc/iceland-amdgcn--.bc
				share/clc/iceland-amdgcn-mesa-mesa3d.bc
				share/clc/juniper-r600--.bc
				share/clc/kabini-amdgcn--.bc
				share/clc/kabini-amdgcn-mesa-mesa3d.bc
				share/clc/kaveri-amdgcn--.bc
				share/clc/kaveri-amdgcn-mesa-mesa3d.bc
				share/clc/mullins-amdgcn--.bc
				share/clc/mullins-amdgcn-mesa-mesa3d.bc
				share/clc/nvptx--.bc
				share/clc/nvptx--nvidiacl.bc
				share/clc/nvptx64--.bc
				share/clc/nvptx64--nvidiacl.bc
				share/clc/oland-amdgcn--.bc
				share/clc/oland-amdgcn-mesa-mesa3d.bc
				share/clc/palm-r600--.bc
				share/clc/pitcairn-amdgcn--.bc
				share/clc/pitcairn-amdgcn-mesa-mesa3d.bc
				share/clc/polaris10-amdgcn--.bc
				share/clc/polaris10-amdgcn-mesa-mesa3d.bc
				share/clc/polaris11-amdgcn--.bc
				share/clc/polaris11-amdgcn-mesa-mesa3d.bc
				share/clc/redwood-r600--.bc
				share/clc/spirv-mesa3d-.spv
				share/clc/spirv64-mesa3d-.spv
				share/clc/stoney-amdgcn--.bc
				share/clc/stoney-amdgcn-mesa-mesa3d.bc
				share/clc/sumo-r600--.bc
				share/clc/sumo2-r600--.bc
				share/clc/tahiti-amdgcn--.bc
				share/clc/tahiti-amdgcn-mesa-mesa3d.bc
				share/clc/tonga-amdgcn--.bc
				share/clc/tonga-amdgcn-mesa-mesa3d.bc
				share/clc/turks-r600--.bc
				share/clc/verde-amdgcn--.bc
				share/clc/verde-amdgcn-mesa-mesa3d.bc