Page MenuHomeFreeBSD
Differential D35256

dummynet: do not store struct ifnet pointers
ClosedPublic
Actions

Authored by kp on May 19 2022, 5:00 PM.
Tags
None
Referenced Files
F133997594: D35256.id106167.diff
Wed, Oct 29, 10:01 PM
F133965573: D35256.id.diff
Wed, Oct 29, 4:03 PM
F133952192: D35256.id106203.diff
Wed, Oct 29, 1:46 PM
F133952087: D35256.id106167.diff
Wed, Oct 29, 1:45 PM
F133952030: D35256.diff
Wed, Oct 29, 1:44 PM
Unknown Object (File)
Fri, Oct 10, 11:03 PM
Unknown Object (File)
Fri, Oct 10, 11:02 PM
Unknown Object (File)
Fri, Oct 10, 11:02 PM
View All Files
Subscribers
ae
donner
glebius
imp
melifaro

Details

Reviewers
None
Group Reviewers
network
pfsense
Commits
rG12c542cd0e9e: dummynet: do not store struct ifnet pointers
Summary

The dn_pkt_tag tag contained a struct ifnet pointer. If we persist that
across NET_EPOCH boundaries (as we did in dummynet) we risk panics if
the interface is removed between the packet being enqueued and it being
dequeued.

Convert the pointer into an index/generation pair and restore it when
the packet is taken out of the queue.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
sys/
netpfil/
ipfw/
10 lines
3 lines

Diff 106203

View Options

sys/netpfil/ipfw/ip_dn_io.c

Loading...
View Options

sys/netpfil/ipfw/ip_dn_private.h

Loading...