Page MenuHomeFreeBSD

Fill the page size array in one posix shm test
ClosedPublic

Authored by andrew on Apr 19 2022, 4:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
May 13 2024, 6:14 PM
Unknown Object (File)
Mar 31 2024, 12:05 PM
Unknown Object (File)
Mar 9 2024, 8:19 AM
Unknown Object (File)
Mar 3 2024, 6:27 PM
Unknown Object (File)
Dec 31 2023, 1:08 PM
Unknown Object (File)
Dec 23 2023, 2:14 AM
Unknown Object (File)
Dec 22 2023, 8:43 AM
Unknown Object (File)
Nov 22 2023, 2:51 PM
Subscribers

Details

Summary

The largepage_config posix shared memory test was failing on arm64 as
the page size array is never filled out. Fix this by calling
getpagesizes(3).

While here skip the test if there is no support for superpages.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tests/sys/posixshm/posixshm_test.c
1258

pagesizes() already checks this.

tests/sys/posixshm/posixshm_test.c
1258

I suspect it should just be (void)pagesizes(ps), to avoid reintroducing the warning that was fixed by cd16a848d1b34016b1a1c663223729a92c247be3.

Remove the page size check

andrew added inline comments.
tests/sys/posixshm/posixshm_test.c
1258

I agree, I'd already changed to that before seeing your second comment.

This revision is now accepted and ready to land.Apr 19 2022, 4:58 PM
This revision was automatically updated to reflect the committed changes.
andrew marked an inline comment as done.