Page MenuHomeFreeBSD
Differential D34852

KTR: Add CTR() and TR() macros which accept a variable number of arguments.
ClosedPublic
Actions

Authored by jhb on Apr 8 2022, 10:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 27, 7:00 PM
Unknown Object (File)
Fri, Sep 27, 6:07 AM
Unknown Object (File)
Tue, Sep 24, 4:42 PM
Unknown Object (File)
Mon, Sep 23, 8:15 AM
Unknown Object (File)
Fri, Sep 20, 12:40 PM
Unknown Object (File)
Thu, Sep 19, 8:59 AM
Unknown Object (File)
Thu, Sep 19, 1:55 AM
Unknown Object (File)
Wed, Sep 18, 9:47 AM
View All 49 Files
Subscribers
debdrup
np
pauamma_gundo.com

Details

Reviewers
emaste
imp
Group Reviewers
manpages
Commits
rG4eb43c2c46ed: KTR: Add CTR() and TR() macros which accept a variable number of arguments.
Summary

These can be used in place of the CTRn() macros which require n to match
the number of optional arguments.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Apr 8 2022, 10:54 PM
Herald added a reviewer: manpages. · View Herald TranscriptApr 8 2022, 10:54 PM
jhb requested review of this revision.Apr 8 2022, 10:54 PM
Harbormaster completed remote builds in B45086: Diff 104789.Apr 8 2022, 10:54 PM
emaste accepted this revision.Apr 9 2022, 1:14 AM

I wonder if we should note in the man page that the CTR macro is newer, which could explain why existing cases in the tree are CTRn.

This revision is now accepted and ready to land.Apr 9 2022, 1:14 AM
jhb added a comment.Apr 9 2022, 1:27 AM
In D34852#789891, @emaste wrote:

I wonder if we should note in the man page that the CTR macro is newer, which could explain why existing cases in the tree are CTRn.

Hmmm, perhaps.

pauamma_gundo.com added a subscriber: pauamma_gundo.com.Apr 9 2022, 2:29 AM
In D34852#789891, @emaste wrote:

I wonder if we should note in the man page that the CTR macro is newer, which could explain why existing cases in the tree are CTRn.

Yeah, I'd like that added to HISTORY.

debdrup added a subscriber: debdrup.Apr 9 2022, 9:17 AM

Manual page syntax looks good, but it'd be nice to have a mention of the timing in the HISTORY section.

pauamma_gundo.com added inline comments.Apr 9 2022, 10:31 AM
share/man/man9/ktr.9
88

Am I reading this right as saying that CTR itself can only handle 5 items to be output using the format argument, vararg or no vararg?

jhb added inline comments.Apr 12 2022, 5:24 PM
share/man/man9/ktr.9
88

Yes, though it's been six for several years. (The original macros from BSD/OS only allowed up to 5).

jhb updated this revision to Diff 104924.Apr 12 2022, 5:28 PM
  • Add a note about CTR() in HISTORY.
This revision now requires review to proceed.Apr 12 2022, 5:28 PM
Harbormaster completed remote builds in B45129: Diff 104924.Apr 12 2022, 5:28 PM
emaste accepted this revision.Apr 12 2022, 5:31 PM
This revision is now accepted and ready to land.Apr 12 2022, 5:31 PM
Closed by commit rG4eb43c2c46ed: KTR: Add CTR() and TR() macros which accept a variable number of arguments. (authored by jhb). · Explain WhyApr 12 2022, 9:53 PM
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG4eb43c2c46ed: KTR: Add CTR() and TR() macros which accept a variable number of arguments..

Revision Contents
Changeset List

PathSize
share/
man/
man9/
17 lines
sys/
sys/
7 lines

Diff 104935

View Options

share/man/man9/ktr.9

Loading...
View Options

sys/sys/ktr.h

Loading...