net: Fix LLE lock leaks
ClosedPublic
Actions

Authored by markj on Apr 7 2022, 7:13 PM.

Details

Reviewers

melifaro
bz

Group Reviewers

network

Commits

rGdd91d8448665: net: Fix LLE lock leaks

Summary

Historically, lltable_try_set_entry_addr() would release the LLE lock
upon failure. After some refactoring, it no longer does so, but now
consumers can leak the LLE lock as a result.

Also fix a leak that can occur if lltable_calc_llheader() fails in the
ARP code, but I suspect that this failure can only occur due to a code
bug.

Reported by: pho
Fixes: 0b79b007ebfc ("[lltable] Restructure nd6 code.")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Apr 7 2022, 7:13 PM

Herald added subscribers: glebius, bz, ae, imp. · View Herald TranscriptApr 7 2022, 7:13 PM

markj requested review of this revision.Apr 7 2022, 7:13 PM

markj added a child revision: D34832: net: Fix memory leaks in lltable_calc_llheader() error paths.

Harbormaster completed remote builds in B45064: Diff 104742.Apr 7 2022, 7:13 PM

bz accepted this revision as: bz.Apr 7 2022, 8:58 PM

This revision is now accepted and ready to land.Apr 7 2022, 8:58 PM

melifaro accepted this revision.Apr 7 2022, 10:28 PM

Closed by commit rGdd91d8448665: net: Fix LLE lock leaks (authored by markj). · Explain WhyApr 8 2022, 4:11 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGdd91d8448665: net: Fix LLE lock leaks.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

if_ether.c

8 lines

netinet6/

nd6_nbr.c

4 lines

Diff 104779

View Options

sys/netinet/if_ether.c