Differential D34710

linprocfs: Add /proc/self/oom_score_adj.
ClosedPublic
Actions

Authored by dchagin on Mar 29 2022, 8:27 PM.

Tags

None

Referenced Files

	F153814292: D34710.id104346.diff
	Thu, Apr 23, 11:32 PM

	F153799044: D34710.id104342.diff
	Thu, Apr 23, 8:27 PM

	Unknown Object (File)
	Sun, Apr 19, 9:13 PM

	Unknown Object (File)
	Sun, Apr 19, 5:22 PM

	Unknown Object (File)
	Sat, Apr 18, 3:21 AM

	Unknown Object (File)
	Fri, Apr 17, 2:47 PM

	Unknown Object (File)
	Fri, Apr 17, 5:46 AM

	Unknown Object (File)
	Fri, Apr 17, 5:31 AM

Subscribers

Details

Reviewers

Group Reviewers

Linux Emulation

Commits

rG708fc30050cd: linprocfs: Add /proc/self/oom_score_adj.
rGb7df7b987e8f: linprocfs: Add /proc/self/oom_score_adj.

Summary

To avoid annoyng messages from LTP test suites add the simple
implementation of /proc/self/oom_score_adj which is do nothing.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dchagin created this revision.Mar 29 2022, 8:27 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 29 2022, 8:27 PM

dchagin requested review of this revision.Mar 29 2022, 8:27 PM

Harbormaster completed remote builds in B44920: Diff 104342.Mar 29 2022, 8:27 PM

dchagin added a reviewer: Linux Emulation.Mar 29 2022, 8:33 PM

dchagin changed the repository for this revision from rS FreeBSD src repository - subversion to rG FreeBSD src repository.

Seems fine to implement as a nop, a couple of comments inline

sys/compat/linprocfs/linprocfs.c
1939	extra comment line
1942	Maybe add some underscores, do_oom_score_adj? dooomscoreadj is hard to read/parse
sys/compat/linux/linux_emul.c
190	Does Linux start at max? That seems somewhat surprising, I'd expect it to default to 0 with the ability to choose more or less susceptible to OOM killer than default.

This revision is now accepted and ready to land.Mar 29 2022, 8:46 PM

fixed, thanks

This revision now requires review to proceed.Mar 29 2022, 9:17 PM

Harbormaster completed remote builds in B44923: Diff 104346.Mar 29 2022, 9:17 PM

emaste accepted this revision.Mar 30 2022, 5:08 PM

This revision is now accepted and ready to land.Mar 30 2022, 5:08 PM

Closed by commit rGb7df7b987e8f: linprocfs: Add /proc/self/oom_score_adj. (authored by dchagin). · Explain WhyMar 31 2022, 6:05 PM

This revision was automatically updated to reflect the committed changes.

dchagin added a commit: rGb7df7b987e8f: linprocfs: Add /proc/self/oom_score_adj..

dchagin added a commit: rG708fc30050cd: linprocfs: Add /proc/self/oom_score_adj..Jun 17 2022, 7:42 PM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linprocfs/

30 lines

linux/

1 line

1 line

4 lines

Diff 104417

sys/compat/linprocfs/linprocfs.c

Loading...

sys/compat/linux/linux_emul.h

Loading...

sys/compat/linux/linux_emul.c

Loading...

sys/compat/linux/linux_misc.h

Loading...