Page MenuHomeFreeBSD
Differential D34574

mem(4): Improve ioctl section formatting
ClosedPublic
Actions

Authored by mhorne on Mar 15 2022, 10:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 8:23 AM
Unknown Object (File)
Fri, May 3, 8:23 AM
Unknown Object (File)
Fri, May 3, 8:23 AM
Unknown Object (File)
Fri, May 3, 8:14 AM
Unknown Object (File)
Fri, May 3, 4:55 AM
Unknown Object (File)
Sat, Apr 20, 4:25 AM
Unknown Object (File)
Sat, Apr 20, 4:25 AM
Unknown Object (File)
Sat, Apr 20, 4:25 AM
View All 56 Files
Subscribers
imp
pauamma_gundo.com

Details

Reviewers
markj
0mp
pauamma_gundo.com
Group Reviewers
manpages
Commits
rG678b6696734e: mem(4): Improve ioctl section formatting
rG071b78ce8fec: mem(4): Improve ioctl section formatting
Summary

Add the missing .El which fixes the indentation of the memory range
definitions and operation. Add subsection headings to further clarify
this section.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 44852
Build 41740: arc lint + arc unit

Event Timeline

mhorne created this revision.Mar 15 2022, 10:11 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 15 2022, 10:11 PM
mhorne requested review of this revision.Mar 15 2022, 10:11 PM
Harbormaster completed remote builds in B44789: Diff 103900.Mar 15 2022, 10:11 PM
mhorne added a child revision: D33813: Add new vnode dumper to support live minidumps.Mar 15 2022, 10:12 PM
pauamma_gundo.com added a subscriber: pauamma_gundo.com.Mar 16 2022, 12:16 AM

English LGTM. Can't vouch for accuracy.

0mp accepted this revision.Mar 16 2022, 8:58 AM
This revision is now accepted and ready to land.Mar 16 2022, 8:58 AM
markj accepted this revision.Mar 21 2022, 4:42 PM
mhorne updated this revision to Diff 104085.Mar 22 2022, 4:32 PM

Add subsections to the Return Values section, and mention explicitly that
MEM_EXTRACT_PADDR always returns zero.

This revision now requires review to proceed.Mar 22 2022, 4:32 PM
Harbormaster completed remote builds in B44852: Diff 104085.Mar 22 2022, 4:32 PM
mhorne mentioned this in D33813: Add new vnode dumper to support live minidumps.Mar 22 2022, 4:33 PM
pauamma_gundo.com accepted this revision as: pauamma_gundo.com.Mar 22 2022, 8:05 PM

WFM English-wise. If others OK the content, it should be good to commit.

This revision is now accepted and ready to land.Mar 22 2022, 8:05 PM
Closed by commit rG071b78ce8fec: mem(4): Improve ioctl section formatting (authored by mhorne). · Explain WhyApr 5 2022, 6:35 PM
This revision was automatically updated to reflect the committed changes.
mhorne added a commit: rG071b78ce8fec: mem(4): Improve ioctl section formatting.
mhorne added a commit: rG678b6696734e: mem(4): Improve ioctl section formatting.Apr 11 2022, 2:05 PM

Revision Contents
Changeset List

PathSize
share/
man/
man4/
10 lines

Diff 104085

View Options

share/man/man4/mem.4

Loading...