Page MenuHomeFreeBSD
Differential D34209

mem(4): allow configuring livedump via ioctl
AbandonedPublic
Actions

Authored by mhorne on Feb 8 2022, 8:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 17, 7:00 PM
Unknown Object (File)
Feb 12 2024, 12:11 AM
Unknown Object (File)
Jan 14 2024, 8:14 AM
Unknown Object (File)
Dec 20 2023, 8:41 AM
Unknown Object (File)
Nov 19 2023, 10:55 PM
Unknown Object (File)
Sep 1 2023, 12:07 AM
Unknown Object (File)
Aug 1 2023, 7:49 AM
Unknown Object (File)
Jul 10 2023, 12:44 PM
View All 14 Files
Subscribers
imp
Contributor Reviews (src)

Details

Reviewers
kib
markj
Summary

This should implement the functionality covered by D34069.

Test Plan

Tested that dumpon -z|Z /dev/mem succeeds and results in a compressed dump.

Need to test the encryption paths.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 44343
Build 41231: arc lint + arc unit

Event Timeline

mhorne created this revision.Feb 8 2022, 8:14 PM
Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptFeb 8 2022, 8:14 PM
mhorne requested review of this revision.Feb 8 2022, 8:14 PM
Harbormaster completed remote builds in B44343: Diff 102511.Feb 8 2022, 8:14 PM
mhorne added a parent revision: D33813: Add new vnode dumper to support live minidumps.Feb 8 2022, 8:14 PM
mhorne edited the summary of this revision. (Show Details)Feb 8 2022, 8:19 PM
mhorne edited the test plan for this revision. (Show Details)
mhorne added reviewers: kib, markj.
mhorne mentioned this in D34069: livedump: add an option for dump compression.Feb 8 2022, 8:33 PM
markj added a comment.Feb 28 2022, 2:41 PM

I'm sorry for the delay.

sys/dev/mem/memdev.c
160

Why exactly do we have separate ioctls for configuring and invoking a livedump? Is it only so that we can have dumpon perform configuration and have savecore actually retrieve the dump? If so I'd really prefer to have savecore do everything, but I see it's a bit inconvenient to have to shoehorn everything there...

OTOH I still can't see a reason we'd want the kernel to perform encryption and compression rather than doing it in userspace. Did we discuss this somewhere already?

markj added a comment.Mar 25 2022, 3:35 PM

Is this review obsolete now?

mhorne abandoned this revision.Mar 25 2022, 7:20 PM
In D34209#785515, @markj wrote:

Is this review obsolete now?

Yep, along with D34069.

Revision Contents
Changeset List

PathSize
sys/
dev/
mem/
33 lines

Diff 102511

View Options

sys/dev/mem/memdev.c

Loading...