Page MenuHomeFreeBSD
Differential D34530

vfs: prefix lookup and relookup with vfs_
ClosedPublic
Actions

Authored by mjg on Mar 11 2022, 4:25 PM.
Tags
None
Referenced Files
F162576515: D34530.diff
Tue, Jul 14, 5:26 PM
Unknown Object (File)
Wed, Jul 8, 5:11 AM
Unknown Object (File)
Tue, Jul 7, 4:03 AM
Unknown Object (File)
Thu, Jun 25, 9:16 AM
Unknown Object (File)
Tue, Jun 23, 7:09 PM
Unknown Object (File)
Mon, Jun 22, 12:03 AM
Unknown Object (File)
Jun 6 2026, 7:08 AM
Unknown Object (File)
Jun 6 2026, 7:07 AM
View All Files
Subscribers
imp

Details

Reviewers
mckusick
markj
jah
imp
Commits
rG0134bbe56fbb: vfs: prefix lookup and relookup with vfs_
Summary

"lookup" is too general of a name and already clashes with other symbols.

No functional changes.

I have some work which refactors the routine and moves parts out of it, need a better name than "lookup".

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mjg created this revision.Mar 11 2022, 4:25 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 11 2022, 4:25 PM
mjg requested review of this revision.Mar 11 2022, 4:25 PM
mjg edited the summary of this revision. (Show Details)
mjg edited the summary of this revision. (Show Details)Mar 11 2022, 4:27 PM
imp accepted this revision.Mar 11 2022, 4:29 PM

lookup is indeed too generic a name.

This revision is now accepted and ready to land.Mar 11 2022, 4:29 PM
mckusick accepted this revision.Mar 13 2022, 1:12 AM

I picked those names when ufs was the only filesystem in BSD. I should have renamed them when I added the VFS interface. Better late than never!

Closed by commit rG0134bbe56fbb: vfs: prefix lookup and relookup with vfs_ (authored by mjg). · Explain WhyMar 13 2022, 2:46 PM
This revision was automatically updated to reflect the committed changes.
mjg added a commit: rG0134bbe56fbb: vfs: prefix lookup and relookup with vfs_.

Revision Contents
Changeset List

PathSize
sys/
fs/
ext2fs/
4 lines
nfsserver/
2 lines
unionfs/
4 lines
kern/
6 lines
sys/
4 lines

Diff 103806

View Options

sys/fs/ext2fs/ext2_vnops.c

Loading...
View Options

sys/fs/nfsserver/nfs_nfsdport.c

Loading...
View Options

sys/fs/unionfs/union_subr.c

Loading...
View Options

sys/kern/vfs_lookup.c

Loading...
View Options

sys/sys/namei.h

Loading...