bhyve: Use vm_get_topology to query kernel's maximum vCPU count.
ClosedPublic
Actions

Authored by jhb on Mar 8 2022, 10:39 PM.

Details

Reviewers

markj
grehan

Group Reviewers

bhyve

Commits

rG31649c585002: bhyve: Use vm_get_topology to query kernel's maximum vCPU count.
rGc76e4b89d9b8: bhyve: Use vm_get_topology to query kernel's maximum vCPU count.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 44705
Build 41593: arc lint + arc unit

Event Timeline

jhb created this revision.Mar 8 2022, 10:39 PM

Herald added a reviewer: bhyve. · View Herald TranscriptMar 8 2022, 10:39 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

jhb requested review of this revision.Mar 8 2022, 10:39 PM

jhb added a parent revision: D34492: bhyve: Don't force an upper bound on vCPUs when parsing pinning..

jhb added a child revision: D34494: bhyve: Remove VM_MAXCPU from the userspace API/ABI..

Harbormaster completed remote builds in B44705: Diff 103654.Mar 8 2022, 10:39 PM

The use of num_vcpus_allowed() could probably be collapsed at some point into calc_topology()

This revision is now accepted and ready to land.Mar 8 2022, 11:11 PM

In D34493#781492, @grehan wrote:

The use of num_vcpus_allowed() could probably be collapsed at some point into calc_topology()

Yeah, it's kind of messy right now as what happens if you use too high a CPU count (e.g. -c 17) you get a cryptic error due to set_topology failing rather than the better error here.

Closed by commit rGc76e4b89d9b8: bhyve: Use vm_get_topology to query kernel's maximum vCPU count. (authored by jhb). · Explain WhyMar 9 2022, 11:58 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGc76e4b89d9b8: bhyve: Use vm_get_topology to query kernel's maximum vCPU count..

jhb added a commit: rG31649c585002: bhyve: Use vm_get_topology to query kernel's maximum vCPU count..May 11 2022, 6:56 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

bhyverun.c

10 lines

Diff 103654

View Options

bhyve: Use vm_get_topology to query kernel's maximum vCPU count.ClosedPublicActions