Differential D34308

Add sysctl hw.acpi and hw.acpi.acline descriptions
Needs ReviewPublic
Actions

Authored by ota_j.email.ne.jp on Feb 17 2022, 3:18 AM.

Details

Reviewers

None

Group Reviewers

manpages

Test Plan

sysctl -d hw.acpi hw.acpi.acline
acline depends on hardware.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 44488
Build 41376: arc lint + arc unit

Event Timeline

ota_j.email.ne.jp created this revision.Feb 17 2022, 3:18 AM

Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptFeb 17 2022, 3:18 AM

ota_j.email.ne.jp requested review of this revision.Feb 17 2022, 3:18 AM

Harbormaster completed remote builds in B44488: Diff 102864.Feb 17 2022, 3:18 AM

ota_j.email.ne.jp retitled this revision from Add hw.acpi and hw.acpi.acline descriptions to Add sysctl hw.acpi and hw.acpi.acline descriptions.Mar 1 2022, 4:59 AM

emaste added a subscriber: emaste.Mar 3 2022, 3:27 PM

emaste added inline comments.

sys/dev/acpica/acpi.c
577	Interface rather than Management?

Management to Interface

Herald added a reviewer: manpages. · View Herald TranscriptMar 6 2022, 5:15 AM

Harbormaster completed remote builds in B44677: Diff 103543.Mar 6 2022, 5:15 AM

ota_j.email.ne.jp added inline comments.Mar 6 2022, 3:25 PM

sys/dev/acpica/acpi.c
577	I had picked this up from man acpi. I adjusted acpi.4 as well.

pauamma_gundo.com added a subscriber: pauamma_gundo.com.Mar 6 2022, 4:41 PM

pauamma_gundo.com added inline comments.

sys/dev/acpica/acpi.c
597	Just noticed that when trying your test plan command. Fix it as well while touching this file?
sys/dev/acpica/acpi_acad.c
177	Why not the complete acpi.4 description, "AC line state (1 means online, 0 means on battery power)"? Too long?