Page MenuHomeFreeBSD
Differential D34110

qcom_mdio: add initial IPQ4018 MDIO support
ClosedPublic
Actions

Authored by adrian on Jan 30 2022, 9:48 PM.
Tags
None
Referenced Files
F109255912: D34110.diff
Sun, Feb 2, 4:41 PM
Unknown Object (File)
Sun, Jan 26, 2:53 AM
Unknown Object (File)
Mon, Jan 20, 2:02 PM
Unknown Object (File)
Fri, Jan 17, 9:16 PM
Unknown Object (File)
Fri, Jan 17, 2:29 PM
Unknown Object (File)
Fri, Jan 17, 1:41 PM
Unknown Object (File)
Fri, Jan 17, 1:22 PM
Unknown Object (File)
Thu, Jan 16, 4:06 AM
View All Files
Subscribers
andrew
imp

Details

Reviewers
manu
imp
Group Reviewers
network
Commits
rG29332c0dcee1: qcom_mdio: add initial IPQ4018 MDIO support
Summary

This adds support for the IPQ4018/IPQ4019 MDIO bus. This is used to
talk to external PHYs and switches. (There's an internal switch
in the IPQ4018/IPQ4019 as well, but it's accessible via MMIO/AXI.)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 44180
Build 41068: arc lint + arc unit

Event Timeline

adrian created this revision.Jan 30 2022, 9:48 PM
Herald added subscribers: andrew, imp. · View Herald TranscriptJan 30 2022, 9:48 PM
adrian requested review of this revision.Jan 30 2022, 9:48 PM
Harbormaster completed remote builds in B44180: Diff 102137.Jan 30 2022, 9:48 PM
adrian added a child revision: D34111: dts: add IPQ4018/IPQ4019 ethernet MAC and ethernet switch definitions.Jan 30 2022, 9:49 PM
adrian mentioned this in D34096: qcom: add initial IPQ4018 MDIO support and etherswitch support.Jan 30 2022, 9:49 PM
adrian added reviewers: manu, imp.
adrian added a reviewer: network.
manu added inline comments.Jan 31 2022, 8:16 AM
sys/dev/qcom_mdio/qcom_mdio_ipq4018.c
294

1/ Does it needs to be that early ? INTERRUPT is really early in the boot, we have BUS_PASS_SUPPORTDEV that usually work for driver like that.
2/ Do you really need to be on simplebus and ofwbus ? In the DTS it's under /soc which is simple-bus compatible so I don't think you need the ofwbus declaration.

manu added a comment.Jan 31 2022, 8:17 AM

mdio and ofw* part looks good, only two questions for me.

adrian updated this revision to Diff 102203.Feb 1 2022, 5:35 AM

Update dates

Harbormaster completed remote builds in B44212: Diff 102203.Feb 1 2022, 5:35 AM
adrian updated this revision to Diff 102204.Feb 1 2022, 5:35 AM

update dates

Harbormaster completed remote builds in B44213: Diff 102204.Feb 1 2022, 5:35 AM
adrian marked an inline comment as done.Feb 1 2022, 5:42 AM
adrian added inline comments.
sys/dev/qcom_mdio/qcom_mdio_debug.h
35

....... whoops, i should fix that

adrian updated this revision to Diff 102207.Feb 1 2022, 5:56 AM

Fix debug

Harbormaster completed remote builds in B44216: Diff 102207.Feb 1 2022, 5:56 AM
adrian updated this revision to Diff 102242.Feb 2 2022, 5:15 AM

address more things

Harbormaster completed remote builds in B44237: Diff 102242.Feb 2 2022, 5:15 AM
manu accepted this revision.Feb 2 2022, 7:35 AM
This revision is now accepted and ready to land.Feb 2 2022, 7:35 AM
adrian updated this revision to Diff 102304.Feb 3 2022, 5:19 AM

update id

This revision now requires review to proceed.Feb 3 2022, 5:19 AM
Harbormaster completed remote builds in B44264: Diff 102304.Feb 3 2022, 5:19 AM
manu accepted this revision.Feb 3 2022, 9:20 AM
This revision is now accepted and ready to land.Feb 3 2022, 9:20 AM
Closed by commit rG29332c0dcee1: qcom_mdio: add initial IPQ4018 MDIO support (authored by adrian). · Explain WhyFeb 4 2022, 5:29 AM
This revision was automatically updated to reflect the committed changes.
adrian added a commit: rG29332c0dcee1: qcom_mdio: add initial IPQ4018 MDIO support.

Revision Contents
Changeset List

PathSize
sys/
arm/
conf/
6 lines
qualcomm/
2 lines
dev/
qcom_mdio/
42 lines
300 lines
47 lines
71 lines

Diff 102137

View Options

sys/arm/conf/std.qca

Loading...
View Options

sys/arm/qualcomm/std.ipq4018

Loading...
View Options

sys/dev/qcom_mdio/qcom_mdio_debug.h

Loading...
View Options

sys/dev/qcom_mdio/qcom_mdio_ipq4018.c

Loading...
View Options

sys/dev/qcom_mdio/qcom_mdio_ipq4018_reg.h

Loading...
View Options

sys/dev/qcom_mdio/qcom_mdio_ipq4018_var.h

Loading...