Page MenuHomeFreeBSD

qcom_mdio: add initial IPQ4018 MDIO support
ClosedPublic

Authored by adrian on Jan 30 2022, 9:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 17 2024, 3:56 AM
Unknown Object (File)
Mar 17 2024, 3:56 AM
Unknown Object (File)
Mar 17 2024, 3:56 AM
Unknown Object (File)
Mar 17 2024, 3:56 AM
Unknown Object (File)
Mar 17 2024, 3:56 AM
Unknown Object (File)
Mar 17 2024, 3:56 AM
Unknown Object (File)
Mar 17 2024, 3:56 AM
Unknown Object (File)
Mar 17 2024, 3:56 AM
Subscribers

Details

Summary

This adds support for the IPQ4018/IPQ4019 MDIO bus. This is used to
talk to external PHYs and switches. (There's an internal switch
in the IPQ4018/IPQ4019 as well, but it's accessible via MMIO/AXI.)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sys/dev/qcom_mdio/qcom_mdio_ipq4018.c
295

1/ Does it needs to be that early ? INTERRUPT is really early in the boot, we have BUS_PASS_SUPPORTDEV that usually work for driver like that.
2/ Do you really need to be on simplebus and ofwbus ? In the DTS it's under /soc which is simple-bus compatible so I don't think you need the ofwbus declaration.

mdio and ofw* part looks good, only two questions for me.

adrian added inline comments.
sys/dev/qcom_mdio/qcom_mdio_debug.h
35

....... whoops, i should fix that

This revision is now accepted and ready to land.Feb 2 2022, 7:35 AM
This revision now requires review to proceed.Feb 3 2022, 5:19 AM
This revision is now accepted and ready to land.Feb 3 2022, 9:20 AM
This revision was automatically updated to reflect the committed changes.