Page MenuHomeFreeBSD

dts: add IPQ4018/IPQ4019 ethernet MAC and ethernet switch definitions
ClosedPublic

Authored by adrian on Jan 30 2022, 9:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 14 2024, 11:03 AM
Unknown Object (File)
Mar 14 2024, 11:02 AM
Unknown Object (File)
Mar 14 2024, 11:02 AM
Unknown Object (File)
Mar 14 2024, 11:02 AM
Unknown Object (File)
Mar 14 2024, 11:02 AM
Unknown Object (File)
Mar 14 2024, 10:59 AM
Unknown Object (File)
Mar 14 2024, 10:59 AM
Unknown Object (File)
Mar 14 2024, 10:48 AM
Subscribers

Details

Summary

This adds the ethernet MAC and ethernet switch definitions from
openwrt.

I've rewritten the header file based on documentation rather than the GPL'ed
one from openwrt.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

The main problem of using a GPL dts is that you use FDT_DTB_STATIC for the ASUS_AC1300 config, which, I think, means that the whole kernel is tainted but IANAL.

IANAL, but the DTS being GPL'd doesn't taint the kernel, per se.
Only building an image with the DTB coupled into the kernel *MIGHT* do that, but I'd argue that that's 'mere aggregation' because the DTB is a separate work from the kernel.

It wouldn't taint the kernel if the boot loader loaded it, or loaded as an overlay.

So I think so long as we, the FreeBSD project, don't build a kernel with qcom-ipq4018-rt-ac58u.dtb statically loaded into it. At worst, qcom-ipq4018-rt-ac58u.dtb would be covered under GPL.
But since there's no comments, and there's only one way to describe the hardware, it's unclear that this file can be copyrighted, casting into doubt any licensing statements. However, that's a big open question and we shouldn't base our actions with that question being decided one way or another.

While we have ASUS_AC1300 as a config file, the project's release tree don't seem to build it. We need to keep it that way.

Note: This is my personal view. I've not discussed this with core@ and they may or may not agree with my analysis.

This revision was not accepted when it landed; it landed in state Needs Review.Feb 4 2022, 5:29 AM
This revision was automatically updated to reflect the committed changes.