dummynet: dn_dequeue() may return NULL
ClosedPublic
Actions

Authored by kp on Jan 28 2022, 11:10 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Oct 14, 9:46 AM

	Unknown Object (File)
	Tue, Oct 14, 9:46 AM

	Unknown Object (File)
	Tue, Oct 14, 9:46 AM

	Unknown Object (File)
	Mon, Oct 13, 7:43 PM

	Unknown Object (File)
	Wed, Oct 1, 6:38 PM

	Unknown Object (File)
	Fri, Sep 19, 5:10 PM

	Unknown Object (File)
	Sep 12 2025, 12:13 PM

	Unknown Object (File)
	Aug 30 2025, 2:05 PM

Subscribers

Details

Reviewers

glebius

Group Reviewers

network
pfsense

Commits

rG9dac026822ab: dummynet: dn_dequeue() may return NULL

Summary

If there are no more entries, or if we fail to restore the rcvif of a
queued mbuf dn_dequeue() can return NULL.
Cope with this.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Jan 28 2022, 11:10 AM

Herald added subscribers: glebius, donner, melifaro and 2 others. · View Herald TranscriptJan 28 2022, 11:10 AM

kp requested review of this revision.Jan 28 2022, 11:10 AM

Harbormaster completed remote builds in B44142: Diff 102045.Jan 28 2022, 11:10 AM

glebius accepted this revision.Jan 28 2022, 5:28 PM

This revision is now accepted and ready to land.Jan 28 2022, 5:28 PM

Closed by commit rG9dac026822ab: dummynet: dn_dequeue() may return NULL (authored by kp). · Explain WhyJan 28 2022, 11:10 PM

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG9dac026822ab: dummynet: dn_dequeue() may return NULL.

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

ipfw/

dn_sched_wf2q.c

2 lines

Diff 102071

View Options

sys/netpfil/ipfw/dn_sched_wf2q.c

dummynet: dn_dequeue() may return NULLClosedPublicActions