Page MenuHomeFreeBSD
Differential D33824

sdhci: Make ext_resources non-optional
ClosedPublic
Actions

Authored by manu on Jan 11 2022, 10:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 13, 9:05 AM
Unknown Object (File)
Fri, Feb 21, 10:41 PM
Unknown Object (File)
Feb 20 2025, 9:24 PM
Unknown Object (File)
Feb 7 2025, 1:54 AM
Unknown Object (File)
Jan 17 2025, 11:53 AM
Unknown Object (File)
Jan 14 2025, 10:16 AM
Unknown Object (File)
Jan 13 2025, 5:04 PM
Unknown Object (File)
Jan 10 2025, 9:25 PM
View All 52 Files
Subscribers
imp
Contributor Reviews (src)

Details

Reviewers
None
Group Reviewers
ARM
Commits
rG69b0498ff8a8: sdhci: Make ext_resources non-optional
rGa813b0965d8e: sdhci: Make ext_resources non-optional
Summary

EXT_RESOURCES have been introduced in 12-CURRENT and all supported
releases have it enabled in their kernel config.

MFC after: 1 month

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
sys/
dev/
sdhci/
12 lines
2 lines

Diff 103050

View Options

sys/dev/sdhci/sdhci_fdt.c

Show First 20 Lines • Show All 497 Lines • ▼ Show 20 Lines if (rm_absent) {
if (pre != 0) if (pre != 0)
di->di_printf("!"); di->di_printf("!");
} else { } else {
/* Last bit of option field determines 32/64 bit offset */ /* Last bit of option field determines 32/64 bit offset */
di->di_printf("%s\t%s, [%s, %s", i_ptr->name, di->di_printf("%s\t%s, [%s, %s", i_ptr->name,
arm64_reg(sf, rt), arm64_reg(1, rn), arm64_reg(sf, rt), arm64_reg(1, rn),
arm64_reg(option & 1, rm)); arm64_reg(option & 1, rm));
if (scale == 0)
amount = 0;
else {
/* Calculate amount, it's op(31:30) */ /* Calculate amount, it's op(31:30) */
amount = (insn >> ARM_INSN_SIZE_OFFSET) & amount = (insn >> ARM_INSN_SIZE_OFFSET) &
ARM_INSN_SIZE_MASK; ARM_INSN_SIZE_MASK;
}
koliagogsadze_gmail.comAuthorUnsubmitted
Done
Inline Actions

or we can use liket this since amount is already initialized

if (scale != 0)
        /* Calculate amount, it's op(31:30) */
        amount = (insn >> ARM_INSN_SIZE_OFFSET) &
	         ARM_INSN_SIZE_MASK;
koliagogsadze_gmail.com: or we can use liket this since `amount` is already initialized ``` if (scale != 0) /*…
switch (option) { switch (option) {
case 0x2: case 0x2:
di->di_printf(", uxtw #%d", amount); di->di_printf(", uxtw #%d", amount);
break; break;
case 0x3: case 0x3:
if (scale != 0) if (scale != 0)
di->di_printf(", lsl #%d", amount); di->di_printf(", lsl #%d", amount);
break; break;
case 0x6: case 0x6:
di->di_printf(", sxtw #%d", amount); di->di_printf(", sxtw #%d", amount);
break; break;
case 0x7: case 0x7:
di->di_printf(", sxts #%d", amount); di->di_printf(", sxtx #%d", amount);
break; break;
default: default:
di->di_printf(", RSVD"); di->di_printf(", RSVD");
break; break;
} }
di->di_printf("]"); di->di_printf("]");
} }
Show All 36 Lines
View Options

sys/dev/sdhci/sdhci_xenon_acpi.c

Show First 20 Lines • Show All 497 Lines • ▼ Show 20 Lines if (rm_absent) {
if (pre != 0) if (pre != 0)
di->di_printf("!"); di->di_printf("!");
} else { } else {
/* Last bit of option field determines 32/64 bit offset */ /* Last bit of option field determines 32/64 bit offset */
di->di_printf("%s\t%s, [%s, %s", i_ptr->name, di->di_printf("%s\t%s, [%s, %s", i_ptr->name,
arm64_reg(sf, rt), arm64_reg(1, rn), arm64_reg(sf, rt), arm64_reg(1, rn),
arm64_reg(option & 1, rm)); arm64_reg(option & 1, rm));
if (scale == 0)
amount = 0;
else {
/* Calculate amount, it's op(31:30) */ /* Calculate amount, it's op(31:30) */
amount = (insn >> ARM_INSN_SIZE_OFFSET) & amount = (insn >> ARM_INSN_SIZE_OFFSET) &
ARM_INSN_SIZE_MASK; ARM_INSN_SIZE_MASK;
}
koliagogsadze_gmail.comAuthorUnsubmitted
Done
Inline Actions

or we can use liket this since amount is already initialized

if (scale != 0)
        /* Calculate amount, it's op(31:30) */
        amount = (insn >> ARM_INSN_SIZE_OFFSET) &
	         ARM_INSN_SIZE_MASK;
koliagogsadze_gmail.com: or we can use liket this since `amount` is already initialized ``` if (scale != 0) /*…
switch (option) { switch (option) {
case 0x2: case 0x2:
di->di_printf(", uxtw #%d", amount); di->di_printf(", uxtw #%d", amount);
break; break;
case 0x3: case 0x3:
if (scale != 0) if (scale != 0)
di->di_printf(", lsl #%d", amount); di->di_printf(", lsl #%d", amount);
break; break;
case 0x6: case 0x6:
di->di_printf(", sxtw #%d", amount); di->di_printf(", sxtw #%d", amount);
break; break;
case 0x7: case 0x7:
di->di_printf(", sxts #%d", amount); di->di_printf(", sxtx #%d", amount);
break; break;
default: default:
di->di_printf(", RSVD"); di->di_printf(", RSVD");
break; break;
} }
di->di_printf("]"); di->di_printf("]");
} }
Show All 36 Lines