Page MenuHomeFreeBSD

budsma: fix boundary alignment test
ClosedPublic

Authored by dougm on Jan 1 2022, 11:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 28, 9:07 PM
Unknown Object (File)
Sat, May 18, 12:08 PM
Unknown Object (File)
May 5 2024, 2:59 PM
Unknown Object (File)
Apr 4 2024, 12:15 AM
Unknown Object (File)
Feb 11 2024, 7:49 AM
Unknown Object (File)
Feb 4 2024, 11:08 PM
Unknown Object (File)
Jan 10 2024, 1:51 AM
Unknown Object (File)
Jan 3 2024, 9:07 AM

Details

Summary

c606ab59e7f9 vm_extern: use standard address checkers everywhere

broke a check in _bus_dmamap_addseg on many architectures. This change makes it clear that it is not a particular range that is being boundary-checked, but the proposed union of the two adjacent ranges.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

dougm requested review of this revision.Jan 1 2022, 11:48 PM

Looks good to me:

increase current segment by sgsize bytes if

  • curraddr is contiguous to the end of the segment,
  • adding sgsize will not cause maxsegsz to be exceeded, and
  • start address plus increased segment length will still pass the boundary check.
This revision is now accepted and ready to land.Jan 2 2022, 1:23 PM
This revision was automatically updated to reflect the committed changes.