bsdinstall: zfsboot: Prompt user for zpool name if the pool already exists

[manu]

Summary

If one install FreeBSD on multiple disks (say 13 and CURRENT) the first created
pool will always be used.
Prompt the user for a new pool name if we detect that the default or supplied one
already exists.

MFC after: 2 weeks
Sponsored by: Beckhoff Automation GmbH & Co. KG

[manu]

BTW if someone could explain this loader/zfs behavior of always using the first created pool that would be nice.
I assumed that loader.efi would detect the disk its on and give the kernel some hints about the pool id or something.

[corvink]

usr.sbin/bsdinstall/scripts/zfsboot

1621

for loop should be breaked after asking for the desired pool name.

[manu]

Break out of loop after prompt

[imp]

In D33331#753599, @manu wrote:

BTW if someone could explain this loader/zfs behavior of always using the first created pool that would be nice.
I assumed that loader.efi would detect the disk its on and give the kernel some hints about the pool id or something.

It's a legacy of the original ZFS implementation. It should do what UFS does and prefer a pool with a disk that matches. I added it to UFS, but ZFS is missing this feature.

[manu]

In D33331#753684, @imp wrote:

In D33331#753599, @manu wrote:

BTW if someone could explain this loader/zfs behavior of always using the first created pool that would be nice.
I assumed that loader.efi would detect the disk its on and give the kernel some hints about the pool id or something.

It's a legacy of the original ZFS implementation. It should do what UFS does and prefer a pool with a disk that matches. I added it to UFS, but ZFS is missing this feature.

Mhm ok, so do we agree on adding this in the meantime that loader is fixed ?

[imp]

In D33331#755800, @manu wrote:

In D33331#753684, @imp wrote:

In D33331#753599, @manu wrote:

BTW if someone could explain this loader/zfs behavior of always using the first created pool that would be nice.
I assumed that loader.efi would detect the disk its on and give the kernel some hints about the pool id or something.

It's a legacy of the original ZFS implementation. It should do what UFS does and prefer a pool with a disk that matches. I added it to UFS, but ZFS is missing this feature.

Mhm ok, so do we agree on adding this in the meantime that loader is fixed ?

Yes. I agree. It's been a lack for a while, and this review doesn't need to fix it.