Page MenuHomeFreeBSD
Differential D33297

LinuxKPI: Add proxy stdarg.h some typical header pollution
ClosedPublic
Actions

Authored by wulf on Dec 6 2021, 10:05 AM.
Tags
None
Referenced Files
F132585486: D33297.id.diff
Sat, Oct 18, 4:46 AM
F132585480: D33297.id101228.diff
Sat, Oct 18, 4:46 AM
F132585478: D33297.id99530.diff
Sat, Oct 18, 4:46 AM
F132533346: D33297.diff
Fri, Oct 17, 6:17 PM
Unknown Object (File)
Thu, Oct 9, 9:47 PM
Unknown Object (File)
Sep 5 2025, 9:03 PM
Unknown Object (File)
Sep 5 2025, 6:39 PM
Unknown Object (File)
Sep 5 2025, 5:08 PM
View All 75 Files
Subscribers
bz
emaste
imp
linuxkpi

Details

Reviewers
• hselasky
manu
Commits
rG6fda5ef279db: LinuxKPI: Add stdarg.h proxy header
rGdf10d8c66781: LinuxKPI: Add some typical header pollution
rG35235d5ff603: LinuxKPI: Add stdarg.h proxy header
rGf1a7639a165d: LinuxKPI: Add some typical header pollution
Summary

To reduce amount of drm-kmod patching

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

wulf created this revision.Dec 6 2021, 10:05 AM
Herald added subscribers: linuxkpi, emaste, imp. · View Herald TranscriptDec 6 2021, 10:05 AM
wulf requested review of this revision.Dec 6 2021, 10:05 AM
Harbormaster completed remote builds in B43182: Diff 99530.Dec 6 2021, 10:05 AM
• hselasky accepted this revision.Dec 6 2021, 10:19 AM

It looks to me like the added includes should be committed separately.

This revision is now accepted and ready to land.Dec 6 2021, 10:19 AM
manu accepted this revision.Dec 6 2021, 11:07 AM
In D33297#752515, @hselasky wrote:

It looks to me like the added includes should be committed separately.

Agreed.

bz added a subscriber: bz.Dec 6 2021, 2:18 PM
bz added inline comments.
sys/compat/linuxkpi/common/include/stdarg.h
27 ↗(On Diff #99530)

Even though we are currently only including our stdarg.h can you please put header guards around it so that it could be extended in the future?

Closed by commit rGf1a7639a165d: LinuxKPI: Add some typical header pollution (authored by wulf). · Explain WhyJan 10 2022, 7:51 PM
This revision was automatically updated to reflect the committed changes.
wulf added a commit: rGf1a7639a165d: LinuxKPI: Add some typical header pollution.
wulf added a commit: rG35235d5ff603: LinuxKPI: Add stdarg.h proxy header.
wulf added a commit: rGdf10d8c66781: LinuxKPI: Add some typical header pollution.Jan 22 2022, 7:39 PM
wulf added a commit: rG6fda5ef279db: LinuxKPI: Add stdarg.h proxy header.

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
3 lines
2 lines
1 line
1 line
1 line

Diff 101228

View Options

sys/compat/linuxkpi/common/include/linux/device.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/fs.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/lockdep.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/slab.h

Loading...
View Options

sys/compat/linuxkpi/common/include/linux/spinlock.h

Loading...