Page MenuHomeFreeBSD
Differential D3282

Add capability to disable CRC stripping. This breaks IPMI/BMC capabilities on certain adatpers.
ClosedPublic
Actions

Authored by sbruno on Aug 3 2015, 6:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 12, 11:31 PM
Unknown Object (File)
Mon, Apr 8, 1:25 PM
Unknown Object (File)
Mon, Apr 8, 10:21 AM
Unknown Object (File)
Thu, Apr 4, 10:20 PM
Unknown Object (File)
Thu, Apr 4, 10:13 PM
Unknown Object (File)
Thu, Apr 4, 4:38 PM
Unknown Object (File)
Thu, Mar 28, 4:52 PM
Unknown Object (File)
Thu, Mar 28, 4:48 PM
View All Files
Subscribers
imp
jfv
wblock

Details

Reviewers
hiren
erj
wblock
Summary

Add system tuneable to disable CRC stripping.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

sbruno updated this revision to Diff 7615.Aug 3 2015, 6:01 PM
sbruno retitled this revision from to Add capability to disable CRC stripping. This breaks IPMI/BMC capabilities on certain adatpers..
sbruno updated this object.
sbruno edited the test plan for this revision. (Show Details)
sbruno added reviewers: erj, hiren.
Herald added a subscriber: imp. · View Herald TranscriptAug 3 2015, 6:01 PM
sbruno added a comment.Aug 3 2015, 6:02 PM

Linux has been doing the exact same thing since 2008

https://github.com/torvalds/linux/commit/eb7c3adb1ca92450870dbb0d347fc986cd5e2af4

sbruno added a comment.Aug 3 2015, 6:03 PM

Original bug:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=161277

hiren accepted this revision.Aug 3 2015, 6:19 PM
hiren edited edge metadata.
This revision is now accepted and ready to land.Aug 3 2015, 6:19 PM
jfv added a subscriber: jfv.Aug 3 2015, 8:00 PM

Cool, surprised this wasn't caught earlier :)

sbruno updated this revision to Diff 7657.Aug 4 2015, 9:01 PM
sbruno edited edge metadata.

Add manpage update for new tuneable, disable_crc_stripping.

This revision now requires review to proceed.Aug 4 2015, 9:01 PM
Herald added a reviewer: manpages. · View Herald TranscriptAug 4 2015, 9:01 PM
hiren accepted this revision.Aug 4 2015, 9:08 PM
hiren edited edge metadata.
wblock added a subscriber: wblock.Aug 5 2015, 2:56 AM

Remember to update .Dd in the man page also, and run igor -R and mandoc -Tlint on it just to be sure. Thanks!

share/man/man4/em.4
209

The second sentence should start on a separate line. The second sentence is kind of a fragment, maybe better with "This is mostly useful on..."

sbruno updated this revision to Diff 7678.Aug 5 2015, 3:25 PM
sbruno edited edge metadata.

Address man page comments/fixups

Herald edited edge metadata. · View Herald TranscriptAug 5 2015, 3:25 PM
sbruno marked an inline comment as done.Aug 5 2015, 3:25 PM
wblock added inline comments.Aug 5 2015, 3:34 PM
share/man/man4/em.4
212

Needs a closing period to be consistent with other entries.

sbruno updated this revision to Diff 7679.Aug 5 2015, 3:38 PM
sbruno edited edge metadata.

Sentences end in periods.

Herald edited edge metadata. · View Herald TranscriptAug 5 2015, 3:38 PM
sbruno marked an inline comment as done.Aug 5 2015, 3:39 PM
wblock accepted this revision.Aug 5 2015, 3:58 PM
wblock added a reviewer: wblock.

Man page changes look okay to me. Thanks!

This revision is now accepted and ready to land.Aug 5 2015, 3:58 PM
erj accepted this revision.Aug 15 2015, 5:30 PM
erj edited edge metadata.
sbruno updated this revision to Diff 7986.Aug 16 2015, 7:04 PM
sbruno edited edge metadata.

Set RDTUN on hw.em.disable_crc_stripping

This revision now requires review to proceed.Aug 16 2015, 7:04 PM
Herald added a reviewer: Intel Networking. · View Herald TranscriptAug 16 2015, 7:04 PM
sbruno removed a reviewer: Intel Networking.Aug 16 2015, 7:48 PM
sbruno removed a reviewer: manpages.
hiren accepted this revision.Aug 16 2015, 9:13 PM
hiren edited edge metadata.
This revision is now accepted and ready to land.Aug 16 2015, 9:13 PM
sbruno closed this revision.Aug 16 2015, 9:17 PM

Revision Contents
Changeset List

PathSize
share/
man/
man4/
7 lines
sys/
dev/
e1000/
7 lines

Diff 7679

View Options

share/man/man4/em.4

Loading...
View Options

sys/dev/e1000/if_em.c

Loading...