Page MenuHomeFreeBSD

net80211: correct length check in ieee80211_ies_expand()
ClosedPublic

Authored by bz on Oct 6 2021, 6:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 25, 7:35 PM
Unknown Object (File)
Sat, Jan 25, 6:18 PM
Unknown Object (File)
Sat, Jan 18, 10:18 PM
Unknown Object (File)
Sat, Jan 18, 5:10 PM
Unknown Object (File)
Mon, Jan 13, 11:10 AM
Unknown Object (File)
Sat, Jan 11, 3:44 AM
Unknown Object (File)
Dec 26 2024, 4:01 PM
Unknown Object (File)
Dec 8 2024, 6:33 PM

Details

Summary

In ieee80211_ies_expand() we are looping over Elements
(also known as Information Elements or IEs).
The comment suggests that we assume well-formedness of
the IEs themselves.
Checking the buffer length being least 2 (1 byte Element ID and
1 byte Length fields) rather than just 1 before accessing ie[1]
is still good practise and can prevent and out-of-bounds read in
case the input is not behaving according to the comment.

Reported by: (coypu sdf.org)
admbugs: 857
MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable