Page MenuHomeFreeBSD

net80211: correct length check in ieee80211_ies_expand()
ClosedPublic

Authored by bz on Oct 6 2021, 6:28 PM.
Tags
None
Referenced Files
F166666671: D32340.diff
Sat, Aug 15, 9:20 AM
Unknown Object (File)
Sun, Aug 9, 4:59 PM
Unknown Object (File)
Sun, Aug 9, 4:58 PM
Unknown Object (File)
Sun, Aug 9, 9:36 AM
Unknown Object (File)
Fri, Aug 7, 7:01 PM
Unknown Object (File)
Fri, Aug 7, 12:45 PM
Unknown Object (File)
Thu, Aug 6, 12:03 PM
Unknown Object (File)
Thu, Aug 6, 9:22 AM

Details

Summary

In ieee80211_ies_expand() we are looping over Elements
(also known as Information Elements or IEs).
The comment suggests that we assume well-formedness of
the IEs themselves.
Checking the buffer length being least 2 (1 byte Element ID and
1 byte Length fields) rather than just 1 before accessing ie[1]
is still good practise and can prevent and out-of-bounds read in
case the input is not behaving according to the comment.

Reported by: (coypu sdf.org)
admbugs: 857
MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable