net/unfs3: Fix build with -fno-common (FreeBSD 13 or later)
ClosedPublic
Actions

Authored by yasu on Sep 29 2021, 8:20 AM.

Details

Reviewers

meta
ygy

Commits

R11:a6dfa43d8f1d: net/unfs3: Fix build with -fno-common (FreeBSD 13 or later)
R11:4c35fa18e743: net/unfs3: Fix build with -fno-common (FreeBSD 13 or later)

Summary

Update MASTER_SITES and WWW as project has moved to GitHub
Take maintainership
Clean up and reformat Makefile

PR: 258326
Approved by: portmgr (unmaintained port), meta (mentor), ygy (mentor)
MFH: 2021Q3

Test Plan

Build succeeds with poudriere and 13.0-RELEASE amd64 jail.
Submitter says it also succeeds with poudriere and FreeBSD 13.0-RELEASE
armv7/aarch64 jail.

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

yasu created this revision.Sep 29 2021, 8:20 AM

Herald added a subscriber: mat. · View Herald TranscriptSep 29 2021, 8:20 AM

yasu requested review of this revision.Sep 29 2021, 8:20 AM

Harbormaster completed remote builds in B41826: Diff 95918.Sep 29 2021, 8:20 AM

Add 'Differential Revision:' to commit message.

Harbormaster completed remote builds in B41827: Diff 95919.Sep 29 2021, 8:21 AM

Take maintainership

Since author field is set to submitter, writing commit messages in submitter's perspective is not wrong but I think "Pass maintainership to submitter" would be clearer.

BTW I personally feel that Approved by: portmgr (unmaintained port) isn't really necessary.

I would also recommend you to pursue submitter to submit patches upstream and/or reference backports.

Update commit message

'Take maintainership' -> 'Pass maintainership to submitter'
Remove 'portmgr (unmaintained port)' from 'Approved by:'

Harbormaster completed remote builds in B41828: Diff 95920.Sep 29 2021, 9:22 AM

Approved, go ahead. Don't forget to do MFH after pushing to main branch.

This revision is now accepted and ready to land.Sep 29 2021, 9:26 AM

In D32220#726911, @diizzy wrote:

I would also recommend you to pursue submitter to submit patches upstream and/or reference backports.

It seems changes in both patch-Config_exports.h and patch-Config_exports.l are already exist in upstream repository.
But it not clear if submitter created them by himself or took them from upstream repository.

Closed by commit R11:4c35fa18e743: net/unfs3: Fix build with -fno-common (FreeBSD 13 or later) (authored by fuz, committed by yasu). · Explain WhySep 29 2021, 9:33 AM

This revision was automatically updated to reflect the committed changes.

yasu added a commit: R11:4c35fa18e743: net/unfs3: Fix build with -fno-common (FreeBSD 13 or later).

yasu added a commit: R11:a6dfa43d8f1d: net/unfs3: Fix build with -fno-common (FreeBSD 13 or later).Sep 29 2021, 9:35 AM

In D32220#726921, @yasu wrote:

In D32220#726911, @diizzy wrote:

I would also recommend you to pursue submitter to submit patches upstream and/or reference backports.

It seems changes in both patch-Config_exports.h and patch-Config_exports.l are already exist in upstream repository.
But it not clear if submitter created them by himself or took them from upstream repository.