Page MenuHomeFreeBSD

net/unfs3: Fix build with -fno-common (FreeBSD 13 or later)
ClosedPublic

Authored by yasu on Sep 29 2021, 8:20 AM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 27 2024, 11:27 PM
Unknown Object (File)
Jan 27 2024, 11:27 PM
Unknown Object (File)
Dec 23 2023, 12:34 AM
Unknown Object (File)
Dec 14 2023, 8:08 PM
Unknown Object (File)
Nov 27 2023, 4:20 PM
Unknown Object (File)
Nov 27 2023, 4:13 PM
Unknown Object (File)
Sep 18 2023, 5:53 AM
Unknown Object (File)
Sep 18 2023, 5:52 AM

Details

Summary
  • Update MASTER_SITES and WWW as project has moved to GitHub
  • Take maintainership
  • Clean up and reformat Makefile

PR: 258326
Approved by: portmgr (unmaintained port), meta (mentor), ygy (mentor)
MFH: 2021Q3

Test Plan

Build succeeds with poudriere and 13.0-RELEASE amd64 jail.
Submitter says it also succeeds with poudriere and FreeBSD 13.0-RELEASE
armv7/aarch64 jail.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

yasu requested review of this revision.Sep 29 2021, 8:20 AM

Add 'Differential Revision:' to commit message.

  • Take maintainership

Since author field is set to submitter, writing commit messages in submitter's perspective is not wrong but I think "Pass maintainership to submitter" would be clearer.

BTW I personally feel that Approved by: portmgr (unmaintained port) isn't really necessary.

I would also recommend you to pursue submitter to submit patches upstream and/or reference backports.

Update commit message

  • 'Take maintainership' -> 'Pass maintainership to submitter'
  • Remove 'portmgr (unmaintained port)' from 'Approved by:'

Approved, go ahead. Don't forget to do MFH after pushing to main branch.

This revision is now accepted and ready to land.Sep 29 2021, 9:26 AM

I would also recommend you to pursue submitter to submit patches upstream and/or reference backports.

It seems changes in both patch-Config_exports.h and patch-Config_exports.l are already exist in upstream repository.
But it not clear if submitter created them by himself or took them from upstream repository.

In D32220#726921, @yasu wrote:

I would also recommend you to pursue submitter to submit patches upstream and/or reference backports.

It seems changes in both patch-Config_exports.h and patch-Config_exports.l are already exist in upstream repository.
But it not clear if submitter created them by himself or took them from upstream repository.

I wrote the patches myself, not looking at what upstream did. But good to hear that the patches can be removed once upstream releases a new version.