powerpc64le: stand fixes
ClosedPublic
Actions

Authored by luporl on Sep 27 2021, 5:37 PM.

Details

Reviewers

bdragon
jhibbits
alfredo

Group Reviewers

PowerPC

Commits

rG8a62b07bce7b: powerpc64le: stand fixes
rGf83288645cd9: powerpc64le: stand fixes

Summary

Fix boot1 and loader on PowerPC64 little-endian (LE).

Due to endian issues, boot1 couldn't find the UFS boot partition
and loader wasn't able to load the kernel. Most of the issues
happened because boot1 and loader were BE binaries trying to access
LE UFS partitions and because loader expects the kernel ELF image
to use the same endian as itself.

To fix these issues, boot1 and loader are now built as LE binaries
on PPC64LE. To support this, the functions that call OpenFirmware
were enhanced to correctly perform endian conversion on its input
and output arguments and to change the CPU into BE mode before
making the calls, as OpenFirmware always runs in BE. Besides that,
some other small fixes were needed.

Most of the changes were done by @bdragon.

Test Plan

Tested on POWER9 VMs, with the following configurations:

BE Hash MMU
BE Radix MMU
LE Hash MMU
LE Radix MMU

Tested both boot from disk as well as netboot.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 42141
Build 39029: arc lint + arc unit

Event Timeline

luporl created this revision.Sep 27 2021, 5:37 PM

Herald added subscribers: dab, imp. · View Herald TranscriptSep 27 2021, 5:37 PM

luporl requested review of this revision.Sep 27 2021, 5:37 PM

Harbormaster completed remote builds in B41784: Diff 95789.Sep 27 2021, 5:37 PM

jhibbits added inline comments.Sep 27 2021, 6:31 PM

stand/common/load_elf.c
752–753	Isn't this a NOP? htobe() on BIG_ENDIAN is a NOP.
797–798	Same here

luporl added inline comments.Sep 27 2021, 8:04 PM

stand/common/load_elf.c
752–753	Yes, I hadn't realized that. This part was causing the kernel to crash at boot on PPC64LE, so I supposed it should be a BE specific stuff. After some digging, it seems it was added by D12421 and D12422, when booting on POWER8 was done with kboot running in LE and the kernel running in BE. The option to compile stand and kboot in LE was later removed with D26430. As this is not the case anymore and the kernel may also be compiled in LE for PowerPC, this should be removed.

Remove obsolete endian conversions

Harbormaster completed remote builds in B41810: Diff 95831.Sep 28 2021, 11:41 AM

luporl marked 2 inline comments as done.Sep 28 2021, 11:42 AM

jhibbits added inline comments.Oct 8 2021, 2:21 PM

stand/powerpc/Makefile
14	uboot is needed for ppc32, too, for the embedded platforms. Maybe an outside SUBDIR.${MK_FDT} for that?

Build uboot for ppc32 too

Harbormaster completed remote builds in B42141: Diff 96874.Oct 14 2021, 5:35 PM

luporl marked an inline comment as done.Oct 14 2021, 5:38 PM

luporl added inline comments.

stand/powerpc/Makefile
14	Ok, it's now being built for all platforms but powerpc64le, keeping the original behavior.

Great job @bdragon and @luporl!
Tested a powerpc64 disc1.iso with this patch on QEMU6.0 and installation went fine. Also tested make buildkernel/installkernel with no issues.

This revision is now accepted and ready to land.Oct 14 2021, 6:06 PM

jhibbits accepted this revision.Oct 20 2021, 6:41 PM

Closed by commit rGf83288645cd9: powerpc64le: stand fixes (authored by luporl). · Explain WhyOct 20 2021, 7:02 PM

This revision was automatically updated to reflect the committed changes.

luporl marked an inline comment as done.

luporl added a commit: rGf83288645cd9: powerpc64le: stand fixes.

luporl added a commit: rG8a62b07bce7b: powerpc64le: stand fixes.Nov 5 2021, 2:31 PM