fsetown: Avoid gotos for error handling
ClosedPublic
Actions

Authored by markj on Aug 24 2021, 9:08 PM.

Tags

None

Referenced Files

	F169385177: D31671.id94143.diff
	Tue, Sep 1, 9:32 AM

	F169321222: D31671.id94191.diff
	Tue, Sep 1, 4:51 AM

	F169258654: D31671.diff
	Tue, Sep 1, 2:08 AM

	F169238582: D31671.id.diff
	Tue, Sep 1, 12:36 AM

	Unknown Object (File)
	Sun, Aug 30, 12:48 AM

	Unknown Object (File)
	Sun, Aug 30, 12:44 AM

	Unknown Object (File)
	Sun, Aug 30, 12:38 AM

	Unknown Object (File)
	Sun, Aug 30, 12:22 AM

View All Files

Subscribers

imp

Details

Reviewers

kib

Commits

rGa507a40f3b58: fsetown: Simplify error handling

Summary

This simplifies control flow somewhat at the expense of extra nesting.

Suggested by: kib

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Aug 24 2021, 9:08 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 24 2021, 9:08 PM

markj requested review of this revision.Aug 24 2021, 9:08 PM

Harbormaster completed remote builds in B41190: Diff 94143.Aug 24 2021, 9:08 PM

markj mentioned this in D31661: Fix a pair of bugs in fsetown().Aug 24 2021, 9:10 PM

kib accepted this revision.Aug 24 2021, 10:28 PM

This revision is now accepted and ready to land.Aug 24 2021, 10:28 PM

Closed by commit rGa507a40f3b58: fsetown: Simplify error handling (authored by markj). · Explain WhyAug 25 2021, 8:31 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGa507a40f3b58: fsetown: Simplify error handling.

Revision Contents
Changeset List

Path

Size

sys/

kern/

kern_descrip.c

106 lines

Diff 94191

View Options

fsetown: Avoid gotos for error handlingClosedPublicActions