Remove unneeded SOLISTENING checks
ClosedPublic
Actions

Authored by markj on Aug 24 2021, 2:01 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Feb 19, 3:10 AM

	Unknown Object (File)
	Tue, Feb 17, 6:26 AM

	Unknown Object (File)
	Sun, Feb 8, 7:39 AM

	Unknown Object (File)
	Sat, Feb 7, 10:45 PM

	Unknown Object (File)
	Sat, Jan 31, 9:40 AM

	Unknown Object (File)
	Dec 27 2025, 3:58 PM

	Unknown Object (File)
	Dec 22 2025, 8:33 PM

	Unknown Object (File)
	Nov 6 2025, 6:18 PM

View All Files

Subscribers

imp

Details

Reviewers

glebius
tuexen

Commits

rG523d58aad179: socket: Remove unneeded SOLISTENING checks

Summary

Now that SOCK_IO_*_LOCK() checks for listening sockets, we can eliminate
some racy SOLISTENING() checks.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Aug 24 2021, 2:01 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 24 2021, 2:01 PM

markj requested review of this revision.Aug 24 2021, 2:01 PM

markj added a parent revision: D31659: socket: Properly interlock when transitioning to a listening socket.

Harbormaster completed remote builds in B41183: Diff 94103.Aug 24 2021, 2:01 PM

(Note that this is not complete, there are still various racy SOLISTENING checks that I'm looking at.)

tuexen accepted this revision.Aug 24 2021, 3:33 PM

This revision is now accepted and ready to land.Aug 24 2021, 3:33 PM

Closed by commit rG523d58aad179: socket: Remove unneeded SOLISTENING checks (authored by markj). · Explain WhySep 7 2021, 9:14 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG523d58aad179: socket: Remove unneeded SOLISTENING checks.

Revision Contents
Changeset List

Path

Size

sys/

kern/

kern_sendfile.c

2 lines

uipc_socket.c

21 lines

Diff 94858

View Options

sys/kern/kern_sendfile.c