Remove unneeded SOLISTENING checks
ClosedPublic
Actions

Authored by markj on Aug 24 2021, 2:01 PM.

Details

Reviewers

glebius
tuexen

Commits

rG523d58aad179: socket: Remove unneeded SOLISTENING checks

Summary

Now that SOCK_IO_*_LOCK() checks for listening sockets, we can eliminate
some racy SOLISTENING() checks.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 41183
Build 38072: arc lint + arc unit

Event Timeline

markj created this revision.Aug 24 2021, 2:01 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 24 2021, 2:01 PM

markj requested review of this revision.Aug 24 2021, 2:01 PM

markj added a parent revision: D31659: socket: Properly interlock when transitioning to a listening socket.

Harbormaster completed remote builds in B41183: Diff 94103.Aug 24 2021, 2:01 PM

(Note that this is not complete, there are still various racy SOLISTENING checks that I'm looking at.)

tuexen accepted this revision.Aug 24 2021, 3:33 PM

This revision is now accepted and ready to land.Aug 24 2021, 3:33 PM

Closed by commit rG523d58aad179: socket: Remove unneeded SOLISTENING checks (authored by markj). · Explain WhySep 7 2021, 9:14 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG523d58aad179: socket: Remove unneeded SOLISTENING checks.

Revision Contents
Changeset List

Path

Size

sys/

kern/

kern_sendfile.c

2 lines

uipc_socket.c

17 lines

Diff 94103

View Options

sys/kern/kern_sendfile.c