Differential D31643

arm64: add read_frequently, read_mostluy and exclusive_cache_line to linker script
ClosedPublic
Actions

Authored by mjg on Aug 23 2021, 11:12 AM.

Details

Reviewers

andrew

Group Reviewers

arm64

Commits

rG766a7c73e92a: arm64: add read_frequently, read_mostluy and exclusive_cache_line to linker…

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mjg created this revision.Aug 23 2021, 11:12 AM

Herald added subscribers: emaste, andrew. · View Herald TranscriptAug 23 2021, 11:12 AM

mjg requested review of this revision.Aug 23 2021, 11:12 AM

andrew added inline comments.Aug 23 2021, 11:29 AM

sys/conf/ldscript.arm64
85	Why 64? If it's related to a cacheline size it should probably be 128 as some CPUs, e.g. the original ThunderX, have a 128 byte cacheline.

flip to 128

mjg marked an inline comment as done.Aug 23 2021, 11:35 AM

mjg added inline comments.

sys/conf/ldscript.arm64
85	it is cache lines, yes

andrew accepted this revision.Aug 23 2021, 12:38 PM

This revision is now accepted and ready to land.Aug 23 2021, 12:38 PM

Closed by commit rG766a7c73e92a: arm64: add read_frequently, read_mostluy and exclusive_cache_line to linker… (authored by mjg). · Explain WhyAug 23 2021, 1:25 PM

This revision was automatically updated to reflect the committed changes.

mjg marked an inline comment as done.

mjg added a commit: rG766a7c73e92a: arm64: add read_frequently, read_mostluy and exclusive_cache_line to linker….

Revision Contents
Changeset List

Path

Size

sys/

conf/

ldscript.arm64

15 lines

Diff 94048

View Options

arm64: add read_frequently, read_mostluy and exclusive_cache_line to linker scriptClosedPublicActions