Page MenuHomeFreeBSD

vmm: Add credential to /dev/vmm.io cdev
AcceptedPublic

Authored by cyril_freebsdfoundation.org on Aug 19 2021, 8:06 PM.
Tags
None
Referenced Files
F132636371: D31615.id93970.diff
Sat, Oct 18, 3:35 PM
Unknown Object (File)
Wed, Oct 15, 10:13 AM
Unknown Object (File)
Wed, Oct 15, 9:48 AM
Unknown Object (File)
Tue, Oct 14, 10:31 AM
Unknown Object (File)
Mon, Oct 13, 8:59 AM
Unknown Object (File)
Mon, Oct 13, 4:21 AM
Unknown Object (File)
Sun, Oct 12, 6:46 PM
Unknown Object (File)
Thu, Oct 2, 11:40 PM
Subscribers

Details

Reviewers
markj
Group Reviewers
bhyve
Summary

The commit a85404906bc8 added a credential for the /dev/vmm cdev but not for /dev/vmm.io. This revision adds the missing credential.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

sys/amd64/vmm/vmm_dev.c
1231

I think it'd be a bit nicer to change devmem_create_cdev() to pass the vmmdev_softc in directly. This function is static, so its usage is confined to this file and there's no real reason to avoid modifying its signature if it makes the code simpler.

This revision is now accepted and ready to land.Aug 20 2021, 7:39 PM