Page MenuHomeFreeBSD

vmm: Add credential to /dev/vmm.io cdev
AcceptedPublic

Authored by cyril_freebsdfoundation.org on Aug 19 2021, 8:06 PM.

Details

Reviewers
markj
Group Reviewers
bhyve
Summary

The commit a85404906bc8 added a credential for the /dev/vmm cdev but not for /dev/vmm.io. This revision adds the missing credential.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

sys/amd64/vmm/vmm_dev.c
1230

I think it'd be a bit nicer to change devmem_create_cdev() to pass the vmmdev_softc in directly. This function is static, so its usage is confined to this file and there's no real reason to avoid modifying its signature if it makes the code simpler.

This revision is now accepted and ready to land.Aug 20 2021, 7:39 PM