Page MenuHomeFreeBSD
Differential D31615

vmm: Add credential to /dev/vmm.io cdev
ClosedPublic
Actions

Authored by cyril_freebsdfoundation.org on Aug 19 2021, 8:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jun 20, 2:16 AM
Unknown Object (File)
Fri, Jun 19, 6:05 PM
Unknown Object (File)
May 23 2026, 11:51 AM
Unknown Object (File)
May 21 2026, 6:07 AM
Unknown Object (File)
May 20 2026, 10:28 PM
Unknown Object (File)
May 20 2026, 2:51 AM
Unknown Object (File)
May 17 2026, 4:00 PM
Unknown Object (File)
May 17 2026, 4:00 PM
View All Files
Subscribers
bcran
imp
rgrimes

Details

Reviewers
markj
Group Reviewers
bhyve
Summary

The commit a85404906bc8 added a credential for the /dev/vmm cdev but not for /dev/vmm.io. This revision adds the missing credential.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

cyril_freebsdfoundation.org created this revision.Aug 19 2021, 8:06 PM
Herald added a reviewer: bhyve. · View Herald TranscriptAug 19 2021, 8:06 PM
Herald added subscribers: bcran, rgrimes. · View Herald Transcript
cyril_freebsdfoundation.org requested review of this revision.Aug 19 2021, 8:06 PM
markj added inline comments.Aug 19 2021, 10:14 PM
sys/amd64/vmm/vmm_dev.c
1231

I think it'd be a bit nicer to change devmem_create_cdev() to pass the vmmdev_softc in directly. This function is static, so its usage is confined to this file and there's no real reason to avoid modifying its signature if it makes the code simpler.

cyril_freebsdfoundation.org updated this revision to Diff 93970.Aug 20 2021, 5:59 PM

Simplify code.

markj accepted this revision as: markj.Aug 20 2021, 7:39 PM
This revision is now accepted and ready to land.Aug 20 2021, 7:39 PM
markj closed this revision.Fri, Jun 5, 2:47 PM

Commit 72ea8f41e19d3 subsumes this diff.

Herald added a subscriber: imp. · View Herald TranscriptFri, Jun 5, 2:47 PM

Revision Contents
Changeset List

PathSize
sys/
amd64/
vmm/
17 lines

Diff 93970

View Options

sys/amd64/vmm/vmm_dev.c

Loading...