Only store the arm64 ID registers in the cpu_desc
ClosedPublic
Actions

Authored by andrew on Jul 29 2021, 9:06 AM.

Details

Reviewers

markj
kib
manu

Group Reviewers

arm64

Commits

rG94cb1b52c178: Only store the arm64 ID registers in the cpu_desc
rG8b3bd5a2b571: Only store the arm64 ID registers in the cpu_desc

Summary

There is no need to store a pointer to the CPU implementer and part
strings. Switch to load them directly into the sbuf used to print them
on boot.

While here print the machine ID register when we fail to determine the
implementer or part we are booting on.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Jul 29 2021, 9:06 AM

Herald added a reviewer: manu. · View Herald TranscriptJul 29 2021, 9:06 AM

Herald added a subscriber: imp. · View Herald Transcript

andrew requested review of this revision.Jul 29 2021, 9:06 AM

Harbormaster completed remote builds in B40739: Diff 92920.Jul 29 2021, 9:06 AM

markj accepted this revision.Jul 29 2021, 11:56 AM

markj added inline comments.

sys/arm64/arm64/identcpu.c
1921

This revision is now accepted and ready to land.Jul 29 2021, 11:56 AM

kib accepted this revision.Jul 29 2021, 1:28 PM

Closed by commit rG8b3bd5a2b571: Only store the arm64 ID registers in the cpu_desc (authored by andrew). · Explain WhyAug 3 2021, 3:43 PM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rG8b3bd5a2b571: Only store the arm64 ID registers in the cpu_desc.

andrew added a commit: rG94cb1b52c178: Only store the arm64 ID registers in the cpu_desc.Aug 30 2021, 12:45 PM

Revision Contents
Changeset List

Path

Size

sys/

arm64/

identcpu.c

112 lines

Diff 93177

View Options

sys/arm64/arm64/identcpu.c

Only store the arm64 ID registers in the cpu_descClosedPublicActions