Page MenuHomeFreeBSD
Differential D30805

vmm: Fix ivrs_drv device_printf usage
ClosedPublic
Actions

Authored by khng on Jun 17 2021, 6:11 PM.
Tags
None
Referenced Files
F157236261: D30805.id91026.diff
Tue, May 19, 2:06 PM
F157200122: D30805.id91080.diff
Tue, May 19, 6:55 AM
Unknown Object (File)
Sun, May 17, 9:38 PM
Unknown Object (File)
Fri, May 15, 5:50 PM
Unknown Object (File)
Fri, May 15, 5:23 PM
Unknown Object (File)
Fri, May 15, 5:23 PM
Unknown Object (File)
Fri, May 15, 5:08 PM
Unknown Object (File)
Fri, May 15, 9:11 AM
View All Files
Subscribers
bcran
imp
jhb
rgrimes

Details

Reviewers
grehan
imp
jhb
Group Reviewers
bhyve
Commits
rGda4e35def95a: vmm: Fix ivrs_drv device_printf usage
rG67d02e13011f: vmm: Fix ivrs_drv device_printf usage
rG210e6aec4f83: vmm: Fix ivrs_drv device_printf usage
Summary

The original %b description string is wrong.

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

khng created this revision.Jun 17 2021, 6:11 PM
Herald added a reviewer: bhyve. · View Herald TranscriptJun 17 2021, 6:11 PM
Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript
khng requested review of this revision.Jun 17 2021, 6:11 PM
Harbormaster completed remote builds in B39958: Diff 91026.Jun 17 2021, 6:11 PM
imp accepted this revision.Jun 17 2021, 9:31 PM
This revision is now accepted and ready to land.Jun 17 2021, 9:31 PM
jhb added a subscriber: jhb.Jun 17 2021, 11:13 PM

Wait, how did this compile exactly? Does it stop at the first invalid character so that '\008' becomes '\0' and '8'?

jhb accepted this revision.Jun 17 2021, 11:13 PM
imp added a comment.Jun 17 2021, 11:24 PM
In D30805#692800, @jhb wrote:

Wait, how did this compile exactly? Does it stop at the first invalid character so that '\008' becomes '\0' and '8'?

\0 and a bit name that starts with a number is legal, but not the expected results

Closed by commit rG210e6aec4f83: vmm: Fix ivrs_drv device_printf usage (authored by khng). · Explain WhyJun 19 2021, 6:09 AM
This revision was automatically updated to reflect the committed changes.
khng added a commit: rG210e6aec4f83: vmm: Fix ivrs_drv device_printf usage.
khng added a commit: rG67d02e13011f: vmm: Fix ivrs_drv device_printf usage.Jul 13 2021, 5:59 PM
khng added a commit: rGda4e35def95a: vmm: Fix ivrs_drv device_printf usage.Sep 3 2021, 7:08 PM

Revision Contents
Changeset List

PathSize
sys/
amd64/
vmm/
amd/
30 lines

Diff 91080

View Options

sys/amd64/vmm/amd/ivrs_drv.c

Loading...