Page MenuHomeFreeBSD

amd64: Avoid enabling interrupts when handling kernel mode prot faults
ClosedPublic

Authored by markj on May 31 2021, 4:19 PM.
Tags
None
Referenced Files
F163085180: D30578.id.diff
Sun, Jul 19, 10:58 PM
F163043974: D30578.id90218.diff
Sun, Jul 19, 1:41 PM
F163019248: D30578.id90218.diff
Sun, Jul 19, 6:19 AM
Unknown Object (File)
Sat, Jul 18, 9:10 AM
Unknown Object (File)
Fri, Jul 17, 10:10 AM
Unknown Object (File)
Mon, Jul 13, 3:30 PM
Unknown Object (File)
Sun, Jul 12, 11:32 AM
Unknown Object (File)
Tue, Jul 7, 3:16 AM
Subscribers

Details

Summary

When PTI is enabled, we may have been on the trampoline stack when iret
faults. So, we have to switch back to the regular stack before
re-entering trap().

trap() has the somewhat strange behaviour of re-enabling interrupts when
handling certain kernel-mode execeptions. In particular, it was doing
this for exceptions raised during execution of iret. When switching
away from the trampoline stack, however, the thread must not be migrated
to a different CPU. Fix the problem by simply leaving interrupts
disabled during the window.

Reported by: syzkaller

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable