Page MenuHomeFreeBSD

amd64: Avoid enabling interrupts when handling kernel mode prot faults
ClosedPublic

Authored by markj on May 31 2021, 4:19 PM.
Tags
None
Referenced Files
F165902661: D30578.id90218.diff
Mon, Aug 10, 11:02 AM
F165902262: D30578.diff
Mon, Aug 10, 11:01 AM
Unknown Object (File)
Fri, Aug 7, 10:41 PM
Unknown Object (File)
Fri, Aug 7, 1:52 PM
Unknown Object (File)
Thu, Aug 6, 12:26 PM
Unknown Object (File)
Thu, Aug 6, 6:30 AM
Unknown Object (File)
Thu, Jul 23, 2:33 PM
Unknown Object (File)
Sun, Jul 19, 10:58 PM
Subscribers

Details

Summary

When PTI is enabled, we may have been on the trampoline stack when iret
faults. So, we have to switch back to the regular stack before
re-entering trap().

trap() has the somewhat strange behaviour of re-enabling interrupts when
handling certain kernel-mode execeptions. In particular, it was doing
this for exceptions raised during execution of iret. When switching
away from the trampoline stack, however, the thread must not be migrated
to a different CPU. Fix the problem by simply leaving interrupts
disabled during the window.

Reported by: syzkaller

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable