Page MenuHomeFreeBSD

Add a first quick and dirty draft of what Git can do with GnuPG.
ClosedPublic

Authored by mat on Apr 12 2021, 2:42 PM.

Diff Detail

Repository
R9 FreeBSD doc repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

mat requested review of this revision.Apr 12 2021, 2:42 PM
mat created this revision.
imp added inline comments.
documentation/content/en/articles/committers-guide/_index.adoc
2205

For the committer's guide, I'd omit this entire paragraph. It's relevance is low for a how-to section, and how we do trust will be something we need to work out in the coming weeks and/or months. I think this paragraph is awkwardly written and a bit unclear. I think those things that it will create a misperception we'll need to clean up later. Ideally, we'd instead point to a trusted source for a more detailed explanation about git's signing model.

documentation/content/en/articles/committers-guide/_index.adoc
2205

That whole paragraph is verbatim from the commit introducing signed pushes. Security is not my thing, and while I understand the concepts, I could not figure out what to write and how to briefly explain signed pushes, so I simply copied it.
It kinda needs to be changed into a quote, but I was out of time.

documentation/content/en/articles/committers-guide/_index.adoc
2220

Perhaps make the above code specific to FreeBSD, so that it doens't clobber other project configurations in case one uses a different ID / key there.

documentation/content/en/articles/committers-guide/_index.adoc
2220

Well, yeah, I wondered about adding or not --global.

documentation/content/en/articles/committers-guide/_index.adoc
2205

The paragraph is out of place and not that useful in this context. It's confusing and doesn't communicate the differences in signing commits, tags etc. That entire discussion is available elsewhere and we should just include something like

To understand the scope of different ways to sign commits, tags, etc, please see <link here>

I can supply the link if need be.

mat marked 3 inline comments as done.Wed, Apr 14, 11:19 AM

rebase and move earlier.

This revision was not accepted when it landed; it landed in state Needs Review.Tue, Apr 27, 6:17 AM
This revision was automatically updated to reflect the committed changes.