Page MenuHomeFreeBSD
Differential D29481

Export sbuf_drain to orchestrate lock and drain action
ClosedPublic
Actions

Authored by rscheff on Mar 29 2021, 9:47 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jul 12, 12:24 AM
Unknown Object (File)
Thu, Jul 9, 11:12 AM
Unknown Object (File)
Sun, Jul 5, 2:34 AM
Unknown Object (File)
Sat, Jul 4, 8:28 AM
Unknown Object (File)
Sat, Jul 4, 2:05 AM
Unknown Object (File)
Fri, Jul 3, 12:43 PM
Unknown Object (File)
Fri, Jul 3, 6:09 AM
Unknown Object (File)
Thu, Jul 2, 7:46 PM
View All Files
Subscribers
imp

Details

Reviewers
tuexen
• ian
jhb
jtl
rrs
thj
Commits
rG6ab67f3b20ac: Export sbuf_drain to orchestrate lock and drain action
rGdc5281a7d439: Export sbuf_drain to orchestrate lock and drain action
rG13d418a967c9: Export sbuf_drain to orchestrate lock and drain action
rGc804c8f2c58b: Export sbuf_drain to orchestrate lock and drain action
Summary

While exporting large amounts of data to a sysctl
request, datastructures may need to be locked.

Exporting the sbuf_drain function allows the
coordination between drain events and held
locks, to avoid stalls.

Test Plan

PR: 254333
MFC after: 2 weeks

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rscheff created this revision.Mar 29 2021, 9:47 AM
Herald added a subscriber: imp. · View Herald TranscriptMar 29 2021, 9:47 AM
Harbormaster completed remote builds in B38150: Diff 86480.Mar 29 2021, 9:47 AM
rscheff requested review of this revision.Mar 29 2021, 9:47 AM
rscheff added a child revision: D29483: tcp: drain tcp_hostcache_list in between per-bucket locks.Mar 29 2021, 8:04 PM
jhb accepted this revision.Mar 31 2021, 3:29 PM
This revision is now accepted and ready to land.Mar 31 2021, 3:29 PM
Closed by commit rGc804c8f2c58b: Export sbuf_drain to orchestrate lock and drain action (authored by rscheff). · Explain WhyMar 31 2021, 5:18 PM
This revision was automatically updated to reflect the committed changes.
rscheff added a commit: rGc804c8f2c58b: Export sbuf_drain to orchestrate lock and drain action.
rscheff removed a child revision: D29483: tcp: drain tcp_hostcache_list in between per-bucket locks.Mar 31 2021, 5:23 PM
rscheff added a commit: rG13d418a967c9: Export sbuf_drain to orchestrate lock and drain action.Apr 16 2021, 7:26 PM
rscheff added a commit: rGdc5281a7d439: Export sbuf_drain to orchestrate lock and drain action.Apr 16 2021, 7:36 PM
rscheff added a commit: rG6ab67f3b20ac: Export sbuf_drain to orchestrate lock and drain action.Apr 16 2021, 7:41 PM

Revision Contents
Changeset List

PathSize
sys/
kern/
2 lines
sys/
1 line

Diff 86627

View Options

sys/kern/subr_sbuf.c

Loading...
View Options

sys/sys/sbuf.h

Loading...