Page MenuHomeFreeBSD
Differential D29442

vm_fault: handle KERN_PROTECTION_FAILURE
ClosedPublic
Actions

Authored by kib on Mar 27 2021, 11:13 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 28, 12:50 PM
Unknown Object (File)
Thu, Nov 27, 3:08 AM
Unknown Object (File)
Wed, Nov 26, 10:47 PM
Unknown Object (File)
Wed, Nov 26, 9:01 PM
Unknown Object (File)
Tue, Nov 25, 6:19 AM
Unknown Object (File)
Sun, Nov 16, 5:54 PM
Unknown Object (File)
Sun, Nov 16, 3:35 PM
Unknown Object (File)
Fri, Nov 14, 8:17 AM
View All Files
Subscribers
None

Details

Reviewers
alc
markj
jah
Commits
rGc7b913aa47ba: vm_fault: handle KERN_PROTECTION_FAILURE
Summary

pmap_enter(PMAP_ENTER_LARGEPAGE) may return KERN_PROTECTION_FAILURE due to PKRU inconsistency. Handle it in the call place from vm_fault_populate(), and in places which decode errors from vm_fault_populate()/vm_fault_allocate().

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib requested review of this revision.Mar 27 2021, 11:13 AM
kib created this revision.
kib mentioned this in D29439: Clean up a couple of MD warts in vm_fault_populate():.
jah accepted this revision.Mar 27 2021, 2:00 PM
This revision is now accepted and ready to land.Mar 27 2021, 2:00 PM
markj accepted this revision.Mar 27 2021, 2:57 PM
markj added inline comments.
sys/vm/vm_fault.c
563

If psind == 0, we do not assert rv == KERN_SUCCESS, but it looks like we should.

markj added inline comments.Mar 27 2021, 2:58 PM
sys/vm/vm_fault.c
563

Never mind, @jah fixed it in D29439.

Closed by commit rGc7b913aa47ba: vm_fault: handle KERN_PROTECTION_FAILURE (authored by kib). · Explain WhyMar 27 2021, 6:48 PM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rGc7b913aa47ba: vm_fault: handle KERN_PROTECTION_FAILURE.

Revision Contents
Changeset List

PathSize
sys/
vm/
7 lines

Diff 86397

View Options

sys/vm/vm_fault.c

Loading...