Paths

Table of Contentst

Differential D29171

bsd.lib.mk: Add a install target for .pc files
ClosedPublic
Actions

Authored by manu on Mar 9 2021, 8:47 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Nov 23, 1:57 AM

	Unknown Object (File)
	Fri, Nov 14, 8:05 AM

	Unknown Object (File)
	Sat, Nov 8, 3:49 AM

	Unknown Object (File)
	Thu, Nov 6, 5:14 AM

	Unknown Object (File)
	Wed, Nov 5, 10:23 AM

	Unknown Object (File)
	Tue, Nov 4, 1:15 PM

	Unknown Object (File)
	Tue, Nov 4, 1:01 PM

	Unknown Object (File)
	Tue, Nov 4, 1:01 PM

Subscribers

freebsd_igalic.co

Details

Reviewers

emaste
bapt

Group Reviewers

Commits

rG8c80fd34167c: bsd.lib.mk: Add a install target for .pc files
rG8a84b3736be1: bsd.lib.mk: Add a install target for .pc files

Summary

That way the files are correctly taggued for pkgbase

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

manu created this revision.Mar 9 2021, 8:47 PM

Herald added subscribers: emaste, imp, bdrewery. · View Herald TranscriptMar 9 2021, 8:47 PM

manu requested review of this revision.Mar 9 2021, 8:47 PM

Harbormaster completed remote builds in B37717: Diff 85438.Mar 9 2021, 8:47 PM

manu added a parent revision: D29170: include: Tag directly the last headers.Mar 9 2021, 8:47 PM

manu added a child revision: D29172: Convert libs with pc files to use PCFILES.

emaste accepted this revision.Mar 9 2021, 9:03 PM

emaste added inline comments.

share/mk/bsd.lib.mk
452	should we have a `.PHONY`?

This revision is now accepted and ready to land.Mar 9 2021, 9:03 PM

manu added inline comments.Mar 9 2021, 9:07 PM

share/mk/bsd.lib.mk
452	I don't think that it's needed, we don't do it for other installlib etc ...

emaste added inline comments.Mar 9 2021, 9:48 PM

share/mk/bsd.lib.mk
452	It will be functional without it indeed, but we would get strange behaviour if we ever end up with a file named as one of these targets for some reason.

manu added inline comments.Mar 10 2021, 9:06 AM

share/mk/bsd.lib.mk
452	Ok, I'll change the .else installpcfiles: .endif to installpcfiles: .PHONY and test, I think that will do the job.

beside the .PHONY thing as stated by @emaste LGTM

Add .PHONY to installpcfiles target.

This revision now requires review to proceed.Mar 11 2021, 12:38 PM

🙋🏻‍♀️

share/mk/bsd.lib.mk
461	i believe we need an `.else` here, or else we'll have this target twice, and one of them will be `.PHONY`

manu added inline comments.Mar 11 2021, 2:25 PM

share/mk/bsd.lib.mk
461	AFAIK this will just either: Create a new empty target with .PHONY attributes if PCFILES isn't defined Set the .PHONY attribute to the already existing target if PCFILES is defined.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 16 2021, 6:14 AM

Closed by commit rG8a84b3736be1: bsd.lib.mk: Add a install target for .pc files (authored by manu). · Explain Why

This revision was automatically updated to reflect the committed changes.

manu added a commit: rG8a84b3736be1: bsd.lib.mk: Add a install target for .pc files.

manu added a commit: rG8c80fd34167c: bsd.lib.mk: Add a install target for .pc files.Jun 30 2021, 7:26 AM

Revision Contents
Changeset List

Path

Size

share/

mk/

14 lines

Diff 85566

share/mk/bsd.lib.mk

Loading...