Page MenuHomeFreeBSD
Differential D29166

pkgbase: Install all cam includes with INCS
ClosedPublic
Actions

Authored by manu on Mar 9 2021, 8:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 20, 11:28 PM
Unknown Object (File)
Sun, Apr 20, 2:23 PM
Unknown Object (File)
Mon, Apr 14, 11:57 AM
Unknown Object (File)
Mar 19 2025, 2:48 AM
Unknown Object (File)
Mar 17 2025, 2:56 AM
Unknown Object (File)
Mar 10 2025, 4:05 PM
Unknown Object (File)
Feb 21 2025, 4:07 PM
Unknown Object (File)
Feb 16 2025, 7:48 PM
View All Files
Subscribers
imp

Details

Reviewers
bapt
Group Reviewers
pkgbase
Commits
rG577dfb1ca15f: pkgbase: Install all cam includes with INCS
rG0594b2879588: pkgbase: Install all cam includes with INCS
Summary

Now they are correctly taggued and put into the -dev package

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
include/
57 lines

Diff 85816

View Options

include/Makefile

Show First 20 Lines • Show All 1,399 Lines • ▼ Show 20 Lines while (1) {
if (intr_disabled) { if (intr_disabled) {
wmesg = "vmhalt"; wmesg = "vmhalt";
VCPU_CTR0(vm, vcpuid, "Halted"); VCPU_CTR0(vm, vcpuid, "Halted");
if (!vcpu_halted && halt_detection_enabled) { if (!vcpu_halted && halt_detection_enabled) {
vcpu_halted = 1; vcpu_halted = 1;
CPU_SET_ATOMIC(vcpuid, &vm->halted_cpus); CPU_SET_ATOMIC(vcpuid, &vm->halted_cpus);
} }
if (CPU_CMP(&vm->halted_cpus, &vm->active_cpus) == 0) { if (CPU_CMP(&vm->halted_cpus, &vm->active_cpus) == 0) {
vm_halted = 1; vm_halted = 1;
markjUnsubmitted
Not Done
Inline Actions

If there are two vcpus, and one is already halted, then we may suspend the VM here. Then the halted vcpu thread can wake up and handle a signal, so the VM will be suspended but halted_cpus != active_cpus. Hmm, but vmx_run() and svm_run() will return VM_EXITCODE_SUSPENDED once the vcpu tries to continue executing the (suspended) guest, so this seems ok.

markj: If there are two vcpus, and one is already halted, then we may suspend the VM here. Then the…
kibAuthorUnsubmitted
Done
Inline Actions

When adding this patch, I wondered if clearing of the bit in halted_cpus should be done under vcpu spin lock. But it seems that vm_resume_cpu() does not care, so I did not do locked the spin lock in the error path as well.

I suspect that vm_suspend() in fact needs more synchronization there, regardless of my fix.

kib: When adding this patch, I wondered if clearing of the bit in halted_cpus should be done under…
break; break;
} }
} else { } else {
wmesg = "vmidle"; wmesg = "vmidle";
} }
t = ticks; t = ticks;
vcpu_require_state_locked(vm, vcpuid, VCPU_SLEEPING); vcpu_require_state_locked(vm, vcpuid, VCPU_SLEEPING);
/* /*
* XXX msleep_spin() cannot be interrupted by signals so * XXX msleep_spin() cannot be interrupted by signals so
* wake up periodically to check pending signals. * wake up periodically to check pending signals.
*/ */
msleep_spin(vcpu, &vcpu->mtx, wmesg, hz); msleep_spin(vcpu, &vcpu->mtx, wmesg, hz);
vcpu_require_state_locked(vm, vcpuid, VCPU_FROZEN); vcpu_require_state_locked(vm, vcpuid, VCPU_FROZEN);
vmm_stat_incr(vm, vcpuid, VCPU_IDLE_TICKS, ticks - t); vmm_stat_incr(vm, vcpuid, VCPU_IDLE_TICKS, ticks - t);
if (td_ast_pending(td, TDA_SUSPEND)) { if (td_ast_pending(td, TDA_SUSPEND)) {
vcpu_unlock(vcpu); vcpu_unlock(vcpu);
error = thread_check_susp(td, false); error = thread_check_susp(td, false);
if (error != 0) if (error != 0) {
if (vcpu_halted) {
CPU_CLR_ATOMIC(vcpuid,
&vm->halted_cpus);
}
return (error); return (error);
}
vcpu_lock(vcpu); vcpu_lock(vcpu);
} }
} }
if (vcpu_halted) if (vcpu_halted)
CPU_CLR_ATOMIC(vcpuid, &vm->halted_cpus); CPU_CLR_ATOMIC(vcpuid, &vm->halted_cpus);
vcpu_unlock(vcpu); vcpu_unlock(vcpu);
▲ Show 20 Lines • Show All 1,535 Lines • Show Last 20 Lines