kern: pull pru_sockaddr call out into sosockaddr()
ClosedPublic
Actions

Authored by kevans on Mar 9 2021, 1:11 PM.

Details

Reviewers

markj
grehan
glebius
melifaro

Summary

We will reuse this in Wireguard to grab the listening port that was
chosen if it was omitted, so we can use a consistent port for udp6 and
export the result to userland.

MFC after: 3 days

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	sys/kern/uipc_socket.c:865	SPELL1	Possible Spelling Mistake
Warning	sys/kern/uipc_socket.c:870	SPELL1	Possible Spelling Mistake
Warning	sys/sys/socketvar.h:420	SPELL1	Possible Spelling Mistake

Unit

No Test Coverage

Build Status

Buildable 37693
Build 34582: arc lint + arc unit

Event Timeline

kevans created this revision.Mar 9 2021, 1:11 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 9 2021, 1:11 PM

Harbormaster completed remote builds in B37693: Diff 85388.Mar 9 2021, 1:11 PM

kevans requested review of this revision.Mar 9 2021, 1:11 PM

kevans added a child revision: D29147: if_wg: choose a port at random if zero/omitted.

This method is used in a number of other places - was it your intention to convert them at some point?

This revision is now accepted and ready to land.Mar 9 2021, 2:59 PM

In D29146#652751, @markj wrote:

This method is used in a number of other places - was it your intention to convert them at some point?

Yup- I'll make a pass in the next couple of days, since I'm about out of immediate wireguard fun to be had.

melifaro accepted this revision.Mar 9 2021, 8:33 PM

melifaro added inline comments.

sys/kern/uipc_socket.c
865	Given other similar functions follow the pattern of `so` `verb` `something`, maybe it's worth naming this `sogetsockaddr()` or `sofillsockaddr()` for consistency?