Page MenuHomeFreeBSD
Differential D29100

mlx5: Print driver version only when creating an interface
ClosedPublic
Actions

Authored by • hselasky on Mar 5 2021, 5:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 30, 10:01 AM
Unknown Object (File)
Sun, Jun 30, 9:59 AM
Unknown Object (File)
Sun, Jun 30, 9:09 AM
Unknown Object (File)
Sun, Jun 30, 8:35 AM
Unknown Object (File)
Sat, Jun 29, 4:35 AM
Unknown Object (File)
Sat, Jun 29, 12:48 AM
Unknown Object (File)
Fri, Jun 28, 10:42 PM
Unknown Object (File)
Fri, Jun 28, 7:03 PM
View All 47 Files
Subscribers
ae
imp
jlduran_gmail.com
koobs

Details

Reviewers
kib
markj
• hselasky
Commits
rG929e8e5605e0: mlx5/mlx4: Bump driver version to 3.7
rGd2cbfbc57b20: mlx5/mlx4: Bump driver version to 3.7
Summary

Otherwise mlx5 unconditionally prints messages to the dmesg during boot,
even when there is no hardware for it to drive.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.Mar 5 2021, 5:56 PM
Herald added subscribers: ae, imp. · View Herald TranscriptMar 5 2021, 5:56 PM
markj requested review of this revision.Mar 5 2021, 5:56 PM
Harbormaster completed remote builds in B37623: Diff 85233.Mar 5 2021, 5:56 PM
jlduran_gmail.com added a subscriber: jlduran_gmail.com.Mar 5 2021, 11:56 PM
• hselasky edited reviewers, added: kib; removed: slavash.Mar 6 2021, 12:31 AM

Need to check this a bit. I will come back on monday with a final answer.

BTW: There is a macro in the LinuxKPI, PRINTK ONCE or something like that, which does exactly like you do. Maybe use that?

• hselasky added a comment.Mar 6 2021, 11:24 AM

I suspect we may just put the printf() under if (bootverbose) .

markj updated this revision to Diff 85295.Mar 7 2021, 2:56 PM

Predicate the printf() on bootverbose.

Harbormaster completed remote builds in B37652: Diff 85295.Mar 7 2021, 2:56 PM
• hselasky added a comment.Mar 8 2021, 9:16 AM

@markj: Do you mind if I commander this revision?

markj added a comment.Mar 8 2021, 5:14 PM
In D29100#652197, @hselasky wrote:

@markj: Do you mind if I commander this revision?

Sure, go ahead.

• hselasky commandeered this revision.Mar 9 2021, 9:38 AM
• hselasky updated this revision to Diff 85369.
• hselasky edited reviewers, added: markj; removed: • hselasky.

Update patch.

markj accepted this revision.Mar 9 2021, 3:09 PM
This revision is now accepted and ready to land.Mar 9 2021, 3:09 PM
• hselasky updated this revision to Diff 85765.Mar 15 2021, 10:04 AM
This revision now requires review to proceed.Mar 15 2021, 10:04 AM
• hselasky updated this revision to Diff 85772.Mar 15 2021, 1:01 PM
markj added inline comments.Mar 15 2021, 4:02 PM
sys/dev/mlx5/mlx5_core/mlx5_main.c
1328

This reintroduces the problem. The line is printed even if no mlx5 hw is present. We already call device_set_desc() here, that ensures that mlx5_version will be printed immediately before attach.

Also there is a newline missing I think.

• hselasky added inline comments.Mar 15 2021, 4:31 PM
sys/dev/mlx5/mlx5_core/mlx5_main.c
1328

No, this is not the device_probe(). This is the device_attach(), and the device_set_desc() is only visible to the sysctl tree. We actually set it too late for it to show up in dmesg :-(

Should work. Can you test it? Or are you sure?

markj added inline comments.Mar 15 2021, 4:42 PM
sys/dev/mlx5/mlx5_core/mlx5_main.c
1328

Sorry, I tested it, you are right. I missed that Linux "probe" is FreeBSD "attach".

We should remove the device_set_desc() call then.

• hselasky added a comment.Mar 15 2021, 6:08 PM

Right now we want both, due to some internal QA/regression tools. Else you are right! Thanks for reviewing.

koobs added a subscriber: koobs.Apr 18 2021, 2:33 AM
• hselasky added a comment.Jun 8 2021, 10:46 AM

This will be upstreamed soon.

• hselasky accepted this revision.Jul 28 2021, 11:37 AM
This revision is now accepted and ready to land.Jul 28 2021, 11:37 AM
Closed by commit rGd2cbfbc57b20: mlx5/mlx4: Bump driver version to 3.7 (authored by • hselasky). · Explain WhyJul 28 2021, 11:48 AM
This revision was automatically updated to reflect the committed changes.
• hselasky added a commit: rGd2cbfbc57b20: mlx5/mlx4: Bump driver version to 3.7.
• hselasky added a commit: rG929e8e5605e0: mlx5/mlx4: Bump driver version to 3.7.Sep 22 2021, 1:03 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
mlx4/
mlx4_core/
4 lines
mlx4_ib/
4 lines
mlx5/
mlx5_core/
4 lines
7 lines
mlx5_en/
16 lines
mlx5_ib/
18 lines

Diff 92850

View Options

sys/dev/mlx4/mlx4_core/mlx4.h

Loading...
View Options

sys/dev/mlx4/mlx4_ib/mlx4_ib_main.c

Loading...
View Options

sys/dev/mlx5/mlx5_core/mlx5_core.h

Loading...
View Options

sys/dev/mlx5/mlx5_core/mlx5_main.c

Loading...
View Options

sys/dev/mlx5/mlx5_en/mlx5_en_main.c

Loading...
View Options

sys/dev/mlx5/mlx5_ib/mlx5_ib_main.c

Loading...