Page MenuHomeFreeBSD

fusefs: fix two bugs regarding fcntl file locks
ClosedPublic

Authored by asomers on Mar 3 2021, 3:31 AM.

Details

Summary
  1. F_SETLKW (blocking) operations would be sent to the FUSE server as F_SETLK (non-blocking).
  1. Release operations, F_SETLK with lk_type = F_UNLCK, would simply return EINVAL.

PR: 253500
Reported by: John Millikin <jmillikin@gmail.com>
MFC after: 2 weeks

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Um, what do you mean by that, @cem ?

sys/fs/fuse/fuse_vnops.c
446

I don't see where flags gets used later, so I suspect this is a dead store and can simply be removed -- fl->l_type should already be correct from the caller, so this should just be a matter of translating op to FUSE_SETLK AFAICT

sys/fs/fuse/fuse_vnops.c
446

Good catch.

  • Remove redundant variable assignment
This revision is now accepted and ready to land.Thu, Mar 18, 8:02 PM