Page MenuHomeFreeBSD
Differential D29031

fusefs: fix two bugs regarding fcntl file locks
ClosedPublic
Actions

Authored by asomers on Mar 3 2021, 3:31 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 19, 7:40 PM
Unknown Object (File)
Tue, May 19, 12:29 PM
Unknown Object (File)
Tue, May 19, 11:31 AM
Unknown Object (File)
Tue, May 19, 9:47 AM
Unknown Object (File)
Mon, May 18, 6:49 PM
Unknown Object (File)
Mon, May 18, 6:49 PM
Unknown Object (File)
Sat, May 16, 7:10 PM
Unknown Object (File)
Fri, May 15, 9:34 AM
View All Files
Subscribers
cem
imp
piotr.konopelko_moosefs.com

Details

Reviewers
kevans
Commits
rG9a9c9e744b51: fusefs: fix two bugs regarding fcntl file locks
rG802271fddbf4: fusefs: fix a dead store in fuse_vnop_advlock
rG9c5aac8f2e84: fusefs: fix a dead store in fuse_vnop_advlock
Summary
  1. F_SETLKW (blocking) operations would be sent to the FUSE server as F_SETLK (non-blocking).
  1. Release operations, F_SETLK with lk_type = F_UNLCK, would simply return EINVAL.

PR: 253500
Reported by: John Millikin <jmillikin@gmail.com>
MFC after: 2 weeks

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 37819
Build 34708: arc lint + arc unit

Event Timeline

asomers created this revision.Mar 3 2021, 3:31 AM
Herald added a subscriber: imp. · View Herald TranscriptMar 3 2021, 3:31 AM
asomers requested review of this revision.Mar 3 2021, 3:31 AM
Harbormaster completed remote builds in B37523: Diff 85036.Mar 3 2021, 3:31 AM
cem resigned from this revision.Mar 3 2021, 5:38 AM

Nah

asomers added a subscriber: cem.Mar 3 2021, 3:04 PM

Um, what do you mean by that, @cem ?

emaste edited reviewers, added: kevans; removed: cem.Mar 8 2021, 3:21 PM
kevans added inline comments.Mar 8 2021, 3:54 PM
sys/fs/fuse/fuse_vnops.c
447

I don't see where flags gets used later, so I suspect this is a dead store and can simply be removed -- fl->l_type should already be correct from the caller, so this should just be a matter of translating op to FUSE_SETLK AFAICT

asomers added inline comments.Mar 13 2021, 10:09 PM
sys/fs/fuse/fuse_vnops.c
447

Good catch.

asomers updated this revision to Diff 85702.Mar 13 2021, 10:11 PM
  • Remove redundant variable assignment
Harbormaster completed remote builds in B37819: Diff 85702.Mar 13 2021, 10:11 PM
kevans accepted this revision.Mar 18 2021, 8:02 PM
This revision is now accepted and ready to land.Mar 18 2021, 8:02 PM
Closed by commit rG9c5aac8f2e84: fusefs: fix a dead store in fuse_vnop_advlock (authored by asomers). · Explain WhyMar 20 2021, 1:42 AM
This revision was automatically updated to reflect the committed changes.
asomers added a commit: rG9c5aac8f2e84: fusefs: fix a dead store in fuse_vnop_advlock.
asomers added a commit: rG802271fddbf4: fusefs: fix a dead store in fuse_vnop_advlock.Apr 8 2021, 2:18 AM
asomers added a commit: rG9a9c9e744b51: fusefs: fix two bugs regarding fcntl file locks.Apr 8 2021, 9:37 PM
piotr.konopelko_moosefs.com added a subscriber: piotr.konopelko_moosefs.com.Jun 26 2021, 2:08 PM

Revision Contents
Changeset List

PathSize
sys/
fs/
fuse/
9 lines
tests/
sys/
fs/
fusefs/
12 lines
45 lines
12 lines

Diff 85702

View Options

sys/fs/fuse/fuse_vnops.c

Loading...
View Options

tests/sys/fs/fusefs/flush.cc

Loading...
View Options

tests/sys/fs/fusefs/locks.cc

Loading...
View Options

tests/sys/fs/fusefs/release.cc

Loading...